[mythtv] [PATCH] volume control for OSS and ALSA

[Jeremiah Morris]

On 26 Oct 2004, at 12:48 PM, David George wrote:

> On 10/26/2004 11:56 AM, Ed Wildgoose wrote:
>
>> David, I'm a bit tied up here.
>
> I'm in a similar boat.  Work is tying me up this week.

Since everyone is busy, I decided to stick my nose in.  Hopefully this 
will help Ed get everything together more quickly once he has time; if 
not, please ignore this message.  ;)

The attached patch (against current CVS) integrates David's code with 
Ed's latest package.  It moves the VolumeControl functions into the 
AudioOutput class, with most of the method implementations in 
AudioOutputBase.  David's ALSA volume code is moved into 
audiooutputalsa.cpp (hopefully I got this added correctly, as I don't 
have an ALSA system for testing).  There's a new method in NVP to 
expose the AudioOutput for the player; tv_play.cpp uses this instead of 
a VolumeControl instance to handle the volume functions.

I also added a previously discussed feature: when muting the left or 
right channel, the data for the other sound channel is duplicated, so 
you get mono sound from both speakers.

With these changes, the VolumeControl class is effectively out of the 
picture for TV watching.  Mythmusic would need stubs for the extra 
AudioOutput methods in its custom output class, but it could still use 
the old VolumeControl for its functionality.  Later, mythmusic can be 
updated to use the standard AudioOutput classes and their integrated 
volume controls.

- Jeremiah
-------------- next part --------------
A non-text attachment was scrubbed...
Name: audio.diff.bz2
Type: application/octet-stream
Size: 9105 bytes
Desc: not available
Url : http://mythtv.org/pipermail/mythtv-dev/attachments/20041026/0cb45cfe/audio.diff.obj