[mythtv] [PATCH] AvFmtDec defaults?

[Daniel Thor Kristjansson]

On Sat, 23 Oct 2004, Kenneth Aafløy wrote:
]> ]The attached patch removes the defaulting to Mpeg2Video and AC3 in
]> ]AvFormatDecoder, it's really just wrong and should be fixed in the
]> ]other end instead.
]> As far as I know it is fixed on the other end, but I'd like to keep this
]> defensive programing in a while. Getting an error message is much nicer
]> than a core dump on the back end for end users. It's easilly converted
]> to an assert if need be.
]I would think forcing the codec to a certain type would cause more harm than 
]good, no?

A change to an assert might be safer. But the only streams that will 
likely trigger this are broadcast MPEG2 streams, so the only real risk 
is choosing AC3 or MPG audio. And printing error messages should make 
diagnosing a problem easier.

]Also there should be a check at the bottom of ScanStreams to check 
]if there really is any usefull streams left..

Why? Do you mean if the codec_type is unrecognized but the codec_id is?

-- Daniel