[mythtv] [patch] frontend segfault with 11/12 CVS for OSD tuner display

[Alan Gonzalez]

Ok I see, you had an audio problem and then returned to the menu.

It seems that in this case nvp->isPlaying() would have been false, yet
this code section assumes playing has occurred.

The code just checked:

        StartPlayerAndRecorder(true, false);
        if (recorder->IsRecording())
        {
            StartPlayerAndRecorder(false, true);
            UpdateOSDInput();
        }
        else
        {
            VERBOSE(VB_IMPORTANT, "LiveTV not successfully started");
            tmpInternalState = internalState;
            nextState = internalState;
            StopPlayerAndRecorder(true, false);
            gContext->RestoreScreensaver();
            recorder = NULL;
        }

The more appropriate place for the UpdateOSDInput() call would have
been lower in the routine at (sorry no line number).  It's here when
we know that playing has occurred.

    if (internalState == kState_WatchingLiveTV)
        UpdateLCD();


On Fri, 12 Nov 2004 20:15:03 -0500, Alan Gonzalez
<alandgonzalez at gmail.com> wrote:
> I see that a fix was committed, but I'm curious..
> 
> Brad did you get a trace of this?  Also can you explain further on
> what you did to get this crash?   From looking at the code
> UpdateOSDInput is only called on ToggleInputs and in HandleStateChange
> when going from None->LiveTV.  So your description confuses me, since
> it seems you were exiting live tv?
> 
> 
> 
> On Fri, 12 Nov 2004 17:25:39 -0500, Brad Fritz <brad-mythtv at fritzfam.com> wrote:
> 
> > The problem was that TV::UpdateOSDInput() was trying to update the OSD
> > when it had not been initialized in NuppelVideoPlayer::StartPlaying()
> > after selecting "Return to menu".
> >
> >
> >
> >
>