[mythtv] [patch] two small fixes

Hamish Moffatt hamish at cloud.net.au
Wed Mar 17 03:38:49 EST 2004

On Wed, Mar 17, 2004 at 05:19:24PM +1030, mian wrote:
> dvbchannel fix ensures the chanid being retrieved for the specified
> channel belongs to a DVB source, this fixes the case where you have two
> channel numbers the same, one on V4L and one on DVB and if the V4L one was
> first in the database it would be retrieved instead.
> -    thequery = QString("SELECT chanid FROM channel WHERE channum='%1'")
> +    thequery = QString("SELECT chanid FROM channel,cardinput,capturecard WHERE channum='%1' && cardinput.sourceid = channel.sourceid && capturecard.cardid = cardinput.cardid && capturecard.cardtype = 'DVB'")
>                         .arg(channum);
>      query = db_conn->exec(thequery);
> Index: libs/libmyth/audiooutputalsa.cpp

Why do you retrieve more fields but then not use them?
(Fields don't need to be selected to include them in there where clause.)

Hamish Moffatt VK3SB <hamish at debian.org> <hamish at cloud.net.au>

More information about the mythtv-dev mailing list