[mythtv] [PATCH] Channel editor : visible setting (alternative)

John Pullan jmp at tarantella.com
Thu Mar 4 12:18:57 EST 2004


So here's a patch which implements a 'hide' rather than a 'visible'
setting. It got a bit tricky because the check box is representing an
inverse of the database value, so I implemented a couple of extra
classes to cope.

Comments ?

Cheers

On Thu, 2004-03-04 at 08:53, John Pullan wrote:
> On Thu, 2004-03-04 at 07:22, Oscar Carlsson wrote:
> > >>JP> This patch adds the visible setting to the channel editor (it was
> > >>JP> pointed out that it was missing on the user list)
> > >>
> > >>JP> You might want to review the label and help text, words ain't my strong
> > >>JP> point :)
> > >>
> > >>I'd make it a "hide" option instead, but maybe that's just me..
> > >>  
> > >>
> > 
> > JDS> It's been called the visible flag since it went in a while ago.  This 
> > JDS> patch just adds it to the gui.
> > 
> > Sure,  but the user doesn't have to know what the internal structure looks like,
> > and I just felt that from a UI perspective a "hide" flag would make more sense.
> > 
> > Like:  "why  wouldn't i want to show this channel if i added it to the database,
> > of course i want it to be visible"..
> > 
> So do we want a new patch or not ? Inverting the logic will require more
> work, not just text changes.
-- 
John Pullan <jmp at tarantella.com>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: channeleditor.alt.patch
Type: text/x-patch
Size: 3619 bytes
Desc: not available
Url : http://mythtv.org/pipermail/mythtv-dev/attachments/20040304/d8e4ae0f/channeleditor.alt.bin


More information about the mythtv-dev mailing list