[mythtv] [PATCH] mythvideo cd support

[Xavier Hervy]

J. Donavan Stanley wrote:

> Xavier Hervy wrote:
> 
>> What does this patch ?
>>
>> mediamonitor_iso9660.diff add volumeid and keyid for iso cd and change
>> mediahandler to allow it to send MythMediaDevice.
>>
>> for mythvideo:
>> mythvideocdsupport.diff + 2 files videoutils.cpp and .h
>> This patch do a lot of thing
>> + allow browsing cd
>> + add cd in database collection (add a table called videostorage)
>> + videotree,videogallery and videobrowse take care about the browse flag
>> (in VideoFilterSettings class)
>> + add last time seen flag, each time you watch a movie the lastseen =
>> curdate ( in videometadata new fields lastseen)
>> + change menu in videogallery by a menu in tree that allow to filter
>> list and group by some fields (instead of filepath)
>> + move all code for playing a video in videoplayer class (in
>> videoutils.h & .cpp)
>> + in videomanager if the imdb is 00000000 and you press select, the
>> movie is search on internet (imdb / allocine) instead of open
>> editmetadata dialog)
>> + add code in metadata.h and .cpp, to manage storage (videostorage)
>>
> 
> Just from skimming the patches without applying them a few things jump 
> out at me:
> 
> 1)  The change to the SELECT behavior  shouldn't be there.  This way 
> we're consistent in what it does and we have zero impact from 
> accidentally hitting SELECT on the wrong video.
I have removed it
> 2) What's with the:  "system("mysql mythconverg -e \"s" stuff
removed
> 3) This patch removes a lot of the utf8 stuff...
should be as before now
> 4) You're using the amount of time the file has been playing to 
> determine if it's been seen.  Problem is, what if I pause the video then 
> exit from it?  It's better to say "if it's played it's watched" then try 
> to guess by using the amount of time the player has been active.
What i do is if player is active more than 50% of the time of the video,
then mythvideo consider that the video has been played today.
50% is arbirtary !
Feel free to change like you prefer.
> 5) There's a lot of commented code here.
removed
> 6) One should never be able to show a video in browse mode that doesn't 
> have it's browse flag active.  There should be no way to toggle the 
> browse flag of a video without passing through the video manager.  That 
> means browse shouldn't be a filter criteria...
> 
file with browse=0 can be shown only in videomanager, and now
videogallery and videotree (except with special option) respect this flag.


My patch should be clean now, sorry for my dirty patch ;-)


TODO :
-optimize getNumVideo in VideoFilterSettings i.e. execute query only if
on criteria have change otherwise return the old store number
- optimize display in videogallery
- integrate parentallevel in videofiltersetting class then the number of
video display in filterdialog and in videobrowser will be the same.

Xavier



-------------- next part --------------
A non-text attachment was scrubbed...
Name: mythvideocdsupport.tar.bz2
Type: application/octet-stream
Size: 24765 bytes
Desc: not available
Url : http://mythtv.org/pipermail/mythtv-dev/attachments/20040630/17c6f36f/mythvideocdsupport.tar.obj