[mythtv] [PATCH] mythvideo cd support

Xavier Hervy maxpower44 at tiscali.fr
Tue Jun 29 18:11:06 EDT 2004


J. Donavan Stanley wrote:

> Xavier Hervy wrote:
> 
>> What does this patch ?
>>
>> mediamonitor_iso9660.diff add volumeid and keyid for iso cd and change
>> mediahandler to allow it to send MythMediaDevice.
>>
>> for mythvideo:
>> mythvideocdsupport.diff + 2 files videoutils.cpp and .h
>> This patch do a lot of thing
>> + allow browsing cd
>> + add cd in database collection (add a table called videostorage)
>> + videotree,videogallery and videobrowse take care about the browse flag
>> (in VideoFilterSettings class)
>> + add last time seen flag, each time you watch a movie the lastseen =
>> curdate ( in videometadata new fields lastseen)
>> + change menu in videogallery by a menu in tree that allow to filter
>> list and group by some fields (instead of filepath)
>> + move all code for playing a video in videoplayer class (in
>> videoutils.h & .cpp)
>> + in videomanager if the imdb is 00000000 and you press select, the
>> movie is search on internet (imdb / allocine) instead of open
>> editmetadata dialog)
>> + add code in metadata.h and .cpp, to manage storage (videostorage)
>>
> 
> Just from skimming the patches without applying them a few things jump 
> out at me:
> 
> 1)  The change to the SELECT behavior  shouldn't be there.  This way 
> we're consistent in what it does and we have zero impact from 
> accidentally hitting SELECT on the wrong video.
i just think is usefull when you add a lot of video in the same time as 
to do INFO + DOWN + SELECT.
And if imdb = 0000000 that means tha video have no info.
but i can remove it.
> 2) What's with the:  "system("mysql mythconverg -e \"s" stuff
Forget to remove debug test
> 3) This patch removes a lot of the utf8 stuff...
I made a mix with a other stuff to try to remove utf8 display and forget 
it, i will remove it too.
> 4) You're using the amount of time the file has been playing to 
> determine if it's been seen.  Problem is, what if I pause the video then 
> exit from it?  It's better to say "if it's played it's watched" then try 
> to guess by using the amount of time the player has been active.
In this time, if you keep the player actif more than 50% of the length 
of the video, then i consider that the video is player. you prefer
"if it's played it's watched" . but it's happen more often that i play 
just the begining of a video than keeping in pause 50% of the length.

The only way to fix the trouble with pouse is to do a internal player.

> 5) There's a lot of commented code here.
I will remove it too
> 6) One should never be able to show a video in browse mode that doesn't 
> have it's browse flag active.  There should be no way to toggle the 
> browse flag of a video without passing through the video manager.  That 
> means browse shouldn't be a filter criteria...
you misunderstand here, actually mythgallery and mythvideo don't take 
care of the browse flag. I add browse flag in videofilter but user can't
choice if he want show browse file or not. the only way to show unbrowse 
file is in video manager. after do this, i made a lot of change in 
videofilter that remove this feature and i forget (again) to do it.
Then i will fix it. but browse flag should be in videofilter otherwise 
you select a criteria, filter dialog say you have n video with these 
criteria, then you return in videobrowser and you have a empty list.


For information, i can never  accede to MediaMonitor::GetMedias in 
videofilter and i don't know why ...
Xavier



More information about the mythtv-dev mailing list