[mythtv] [PATCH] Specify aspect ratio cycle

[Hamish Moffatt]

On Thu, Jun 03, 2004 at 12:21:28AM +0200, Kristof Pelckmans wrote:
> > Good idea. However I think you changed the default order, which violates
> > the principle of least surprise. Currently it is:
> >
> >     kLetterbox_4_3 = 0,
> >     kLetterbox_16_9,
> >     kLetterbox_4_3_Zoom,
> >     kLetterbox_16_9_Zoom,
> >     kLetterbox_16_9_Stretch,
> 
> It was due to the standard behaviour of QMap : the items are sorted
> alphabetically (by key) when iterating over the map.

Hi Kristof,

I tried your patch and indeed now it uses the standard order for the
modes. The only problem is that it doesn't take into account the
default mode.

In my setup (DVB-T), all the captured material is 16:9, so the video
player starts in 16:9. When I first hit W to change modes, it goes to
the start of the list (4:3), then next hit takes me to 16:9, next to 4:3
Zoom, etc. Previously Myth would know that I was already on 16:9 and so
the first press of W would take me to 4:3 Zoom.

I have not tried customising the list yet. But I think if I put
"16:9, 16:9 Zoom" in the list, then the first hit of W will take
me from 16:9 to 16:9 ie no change.

Nice feature though! Thanks for taking all my criticism. :-)

Hamish
-- 
Hamish Moffatt VK3SB <hamish at debian.org> <hamish at cloud.net.au>