[mythtv] [PATCH] mythvideo

[J. Donavan Stanley]

Xavier Hervy wrote:

> Hi Donovan
> J. Donavan Stanley wrote:
>
>> Xavier Hervy wrote:
>>
>>> I remove too the umount option because this don't work, don't know 
>>> why, probably the cd monitoring feature made this problem.
>>
>>
>>
>> I thought I'd written the media manager ...
>
> Yes, great feature, i never thank you enough !
>
>> ... so that it would unlock the drive tray and unmount the disk if 
>> you opened the tray I could be wrong though it's been a while.  
>
> If i don't have supermount option, i can't open the drive without umount.
> it's why i put the option "Action after cd use":
> -Do nothing (for those that have supermount)
> -eject (for those don't have, "eject" will be execute)

I don't use supermount either.  I could have sworn I had managed to 
force an unlock of the tray though.

> I have removed the umount option.
> Do you mean, that i should ask mediamonitoring to eject itself the cd ?
> I don't understand how i should do that !

They way it's supposed to work is that the media monitor will see a data 
disk is inserted and mount it where it belongs according to the fstab.  
It will then unlock the drive tray allowing the disk to be ejected.  
Once the tray has been opened the media monitor will see that on the 
next loop around and unmount the disk.

> > You might want to look at the media
>
>> monitoring code and see about routing the information about the disk 
>> as part of the event, that way you don't need to ask about a mount 
>> point.  Alternatively, parse the /etc/fstab yourself and figure out 
>> where to mount the disk.
>
> do you mean that VideoCDMountPoint setting shouldn't exist ?


Correct.  The mediamonitor knows the details about the drive,  such as 
the device name and where it's mounted.  It's just a matter of filtering 
that down to the media handler that responds to the event.


>>
>> Please try to follow the style of the existing codebase..  Tabs are 
>> bad mkay?
>
> If i understood you, i use should use space instead of tab ?

Yes, tabs are horrid evil things to be avoided at all costs.