[mythtv] Mac OS X patch 17

[Nigel Pearson]

On Wednesday 30 June 2004 02:52 am, Nigel Pearson wrote:
> V4L is not on Mac OS X, so #ifndef _WIN32 is inappropriate
> Use config.h to determine if this platform has V4L APIs

On Jul 3, 2004, at 1:50 PM, Isaac Richards wrote:
> config.h isn't generated by mythtv code, so it shouldn't be relied on.

	True, but the two alternatives are:

a) In any source that uses V4L, add
    #if defined(__linux__) || defined(__FreeBSD__)
    plus any other future platforms that people decide to port
    the backend to. I figured that using configure was more
    likely to "just work" in the future.

b) Duplicating the login of configure in settings.pro
    e.g. adding -DCONFIG_VIDEO4LINUX in linux, freebsd, netbsd


	Also:

1) Most people compiling Unix source code do:
       ./configure
       make
    without even thinking
    (and then read the doco that says to qmake mythtv.pro :-)

2) Anyone porting to a new platform _should_ realise that
    they must run configure before compiling

3) We could put code into libmythtv.pro to check that config.h
    has been generated (like currently in libav*.pro)


	Anyway, it sounds like you and Matt would prefer option b),
so here is another patch

-------------- next part --------------
A non-text attachment was scrubbed...
Name: patch.macosx.18
Type: application/octet-stream
Size: 1626 bytes
Desc: not available
Url : http://mythtv.org/pipermail/mythtv-dev/attachments/20040705/22daaa23/patch.macosx.obj
-------------- next part --------------


--
Nigel Pearson, nigel at ind.tansu.com.au | "Reality is that which,
Telstra BI&D, Sydney, Australia       |  when you stop believing
Office: 8255 4222    Fax:  8255 3153  |  in it, doesn't go away."
Mobile: 0408 664435  Home: 9792 6998  |  Philip K. Dick - 'Valis'