[mythtv] [PATCH] mythvideo cd support
maxpower44 at tiscali.fr
Sun Jul 4 04:39:36 EDT 2004
thanks for your help.
Matt Porter wrote:
> On Thu, Jul 01, 2004 at 11:09:55PM +0200, Xavier Hervy wrote:
>>I made a patch for media monitoring that allow MythDialog to intercept
>>mediahandler before that mediamonitoring close activewindow and open the
>>Actually it's work great in mythvideo.
> I agree, it works great when prompted to insert the media in the
> browser. Performing a context sensitive handler event is much nicer
> than blindly calling the handler again.
>>I also update my patch to remove some cout, i have forget to remove, fix
>> few little bug in videofilter.
> There's still some old code cruft in videoutils.cpp that's commented
> out, you should remove that (updatePlayWait).
> I isolated the segfault I was seeing when cancelling the insertion
> request from the videobrowser. I've attached a patch for that
> versus your patchset, please consider including it. Also, with
> onMediaEvent(), there's no need to have a Retry button, so I changed
> it to just focus on Cancel since onMediaEvent() will emit the
> retry signal when the user inserts the media.
I have not removed Retry button because i'm thinking about people that
don't use mediamonitoring. in fact, users who don't use mediamonitor
can't use amovible storage then it was stupid. I removed it like you
> I still have a segfault in videogallery, but I'm going to take a
> break and look at that in a bit.
Just to now, did you have a segfault too, when you go in Video Browser
-> Video Filter or only in videogallery. it's to know if segfault come
from videogallery or video filter.
More information about the mythtv-dev