[mythtv] Scheduler patch update.

[Steve Davies]

David Engel wrote:
> On Wed, Jan 21, 2004 at 09:18:34PM +0000, Steve Davies wrote:
> 
>>New patch attached.
> 
> Here are my comments.

Appreciated, thank you.
> 
> First off, would you mind me not doing anything with this until after
> Myth 0.14 is released?  There's some (hopefully, not too major)
> restructuring of the scheduler I'd like to do but I don't want to do
> any more to it right now except fix bugs before the release.

Not at-all. That sounds quite sensible. I hope I'll be able to offer a 
re-worked patch against post 0.14 CVS when that's done.
> 
> When ProgramInfo::IsSameProgram is called with different values of
> use_xmltvid, the checks are totally different.  Why didn't you keep
> the change in IsSameProgramTimeslot?
> 
The use_xmltvid chack falls through to the original one, hence its placement 
in that method.

The existing code uses ProgramInfo::IsSameProgram in the scheduler, and I 
realised what I was trying to do was extend the detection of "same" programs 
to include "adjacent" ones (on another input, card or source) - This fits 
perfectly in ProgramInfo::IsSameProgram, but was a bit of a crowbar to add to 
IsSameProgramTimeslot - I want an exact match, so it no longer worked after 
your recent patch.

> In ScheduledRecording::findAllProgramsToRecord, can you add
> channel.xmltvid to the end of the select list and not change the other
> indenting?  This would help keep the patch cleaner and easier to
> understand.

Oops. my bad - My editor tries to use TABs, and I am constantly messing up 
whitespace :-) I'll relocate the extra field also.

> 
> David

As it happens, I had another flash of inpiration based on comments you made 
the other day - I am now experimenting with a scheduler that can do without 
DoMultiCard() and MarkKnownInputs() completely!!! In fact I have a working 
prototype already, but it schedules cards without consideration for their 
priority at the moment.

I'll keep you posted.
Steve

-- 
Steve Davies                   steve at one47.co.uk

PGP Fingerprints:
DH/DSS : 5D85 8164 91D7 E9CC 4F80  842B AB86 93D9 8938 7612
RSA    :      4E2E E60F 3D76 9E7E  70F9 901B 70FA 56C8
RSA4096: 02BE 5C0E EFA2 E1E4 EA89  C9CC 1E4F F654 3BC7 B65E