[mythtv] Re: [mythtv-commits] mythtv commits

[Steve Davies]

David Engel wrote:
> 
> I'm still unclear as to why the looser check doesn't work for you.
> The chanid check still requires an exact match and probably makes the
> sourceid check superfluous.

I THINK the problem I was having is that the test now says "does the 'other' 
program lie inside the bounds of the 'current' program." If the method is 
called in reverse, then the meaning is negated. I might have been calling it 
with the parameters back-to-front.

Now that I look at it, I'm not sure I ever need to call 
IsSameProgramTimeslot() anyway! I'll check.

> 
>>The patch also fixes up some common scheduler omissions which I've seen 
>>mentioned on the list.
> 
> Care to elaborate?  I know of one issue I was going to look into later
> today.

One is the scenario where A overlaps B, and B overlaps C. The scheduler MIGHT 
disable A to allow B to record, and then disable B to allow C to record. A can 
now be recorded, so I have added a pass to check for auto-disabled programs 
which can be recorded after-all.

There is also the case where conflict resolution fails, but there is an 
"rsOtherShowing" available that the scheduler missed because it was originally 
conflicting with something. The same pass finds these, and uses them if possible.

> 
>>Perhaps I should send you the (updated) patch off-list for approval?
> 
> 
> Unless there's a good reason not to, please send it to the list.
> 
I'll post an updated patch soon.

Regards,
Steve

-- 
Steve Davies                   steve at one47.co.uk

PGP Fingerprints:
DH/DSS : 5D85 8164 91D7 E9CC 4F80  842B AB86 93D9 8938 7612
RSA    :      4E2E E60F 3D76 9E7E  70F9 901B 70FA 56C8
RSA4096: 02BE 5C0E EFA2 E1E4 EA89  C9CC 1E4F F654 3BC7 B65E