[mythtv] Fwd: [PATCH] MPEG2->MPEG2 commercial cut (myth patchrev-b)

[Geoffrey Hausheer]

it should apply cleanly against CVS.  Is it not doing so?
.Geoff
On Sat, 10 Jan 2004 12:46:50 -0500, "DBakker-at-arrayasolutions.com
|mythtv/1.0-Allow|" <liathq2esu0t at sneakemail.com> said:
> Is this patch meant to go against the latest cvs or version 13?
> 
> 
> 
> 
> "Geoffrey Hausheer" <ou401cru02 at sneakemail.com> 
> Sent by: mythtv-dev-bounces at mythtv.org
> 01/10/2004 10:17 AM
> Please respond to
> Development of mythtv <mythtv-dev at mythtv.org>
> 
> 
> To
> mythtv-dev at mythtv.org
> cc
> 
> Subject
> [mythtv] Fwd: [PATCH] MPEG2->MPEG2 commercial cut (myth patch rev-b)
> 
> 
> 
> 
> 
> 
> Let's try it again...with FEELING this time...
> 
> 
> ----- Original message -----
> This patch is yet another minor revision of the mpeg2->mpeg2 commercial
> cut code.
> 
> The commercial cutting should work now (REALLY).  I also changed how
> video PTS are written slightly
> No other significant changes over the 18a patch.
> 
> As for why the files generated are smaller than the originals even when
> no commercial-cutting is done, we remove all 'PAD' frames from the
> stream.  This should not directly impact the stream's compliance, however
> it is possible that it does so.
> 
> Specifically, it appears that the packet rate is constrained when either
> the 'fixed' or 'CSPS' flags are enabled (and libavformat sets both of
> these).  This appears to enforce the arrival times of any given
> audio/video packet, and I am guessing that the padding frames are used to
> align to those speced values.
> 
> I have temporarily disabled setting the fixed and CSPS streams.  While
> this is legal MPEG2 format, it may not be well supported by all players.
> 
> I'd appreciate comments on whether this makes the streams play better or
> not.
> 
> Either way, I probably need to look into ensuring that we obey the
> packet-timing rules to make the output as compatible as possible.
> 
> To Do:
> Try to make streams more compatible with other players.
> 
> These streams work well for me in mythtv, and so I plan to finish the
> integration next rather than banging my head against compatibility some
> more.  So hopefully the next patch will support updating the
> recordedmarkup table.  However, if you are still having playback issues
> (especially when playing-back using mythfrontend), please let me know.
> 
> .Geoff
> [attachment "transcode18b.patch.gz" deleted by David F. 
> Bakker/arrayasolutions] _______________________________________________
> mythtv-dev mailing list
> mythtv-dev at mythtv.org
> http://mythtv.org/cgi-bin/mailman/listinfo/mythtv-dev
>