[mythtv] problem with delete button "Yes, but record..." missing

Chris Pinkham cpinkham at bc2va.org
Thu Feb 12 17:06:00 EST 2004


> >     if ((dupmethod & kDupCheckSub) &&
> >         ((subtitle == "") ||
> >          (subtitle != other.subtitle)))
> >         return false;
> > 
> >     if ((dupmethod & kDupCheckDesc) &&
> >         ((description == "") &&
>                                 ^^^^^
> Should this read "||" instead of "&&" ?
> 
> Steve

Yes, just corrected this and am about to commit.

> > I think that's a whole lot easier to read than the previous large "if"
> > statement.  Appears to work correctly here, can you guys give current CVS
> > a shot?
> > 
> I agree... But the "length > 2" checks on subtitle and description are now 
> still in the SELECT statement in the scheduler, but not in the IsSameProgram 
> method. I think they should match up more closely.

Which select?

Scheduler::AddFuturePrograms() uses <> '' as a comparison.
Scheduler::PruneList() checks for items with length() <= 2.


-- 

Chris



More information about the mythtv-dev mailing list