[mythtv] [PATCH] wrapping navigation for menus

Spencer Jason E CONT DLVA SpencerJE at NSWC.NAVY.MIL
Tue Feb 10 08:55:42 EST 2004


> 
> 
> On Saturday 07 February 2004 12:54, Isaac Richards wrote:
> > On Friday 06 February 2004 10:01 am, Joseph A. Caputo wrote:
> > > On Friday 06 February 2004 00:59, Isaac Richards wrote:
> > > > On Tuesday 03 February 2004 11:05 am, Joseph A. Caputo wrote:
> > > > > The attached patch implements a rudimentary 
> 'wrapping' behavior for
> > > > > ThemedMenu.  It's kind of a hack; it doesn't handle 
> PgUp/PgDown at
> > > > > all, and it doesn't do anything to adjust the screen 
> position of
> > > > > the menu (i.e., if you 'wrap' back from the top of a 
> single-column
> > > > > menu to the bottom, the whole display shifts so that 
> the current
> > > > > item is now at the bottom).
> > > > >
> > > > > It's not elegant, but at least it relieves some of the tedium
> > > > > associated with navigating menus with lots of items.
> > > > >
> > > > > Oh, and for multi-column menus (blue theme, e.g.), 
> column wrapping
> > > > > is also implemented.  Moving off the end of a column will also
> > > > > increment/decrement the current row.
> > > >
> > > > I'm not sure if I want to apply this -- the menu used 
> to work this
> > > > way (long time ago), and I eventually decided that I 
> really didn't
> > > > like this behavior, so I removed it.
> > >
> > > Ah yes, I vaguely recall that... however that was before 
> all of the
> > > new-fangled single-column themes came onto the scene.  How about a
> > > version of the patch that only exhibited the wrapping behavior for
> > > single-column menus?
> > 
> > Hmm.  Yeah, that'd work for me =)
> 
> Sorry it's taken so long... here's a trimmed down version of 
> the patch that 
> only enables wrapping for single-column themes.
> 
> I'm thinking about adding to this patch so that for 
> single-column themes, the 
> current choice is always centered in the list (so that the 
> indicator appears 
> stationary & the list appears to 'move' through it).  Would 
> this be accepted?
> 
> -JAC

Thanks for the work, I've been using your previous patch on my xbox
(no pgup/pgdwn mapped on the remote).  I'll be interested in your new
idea/patch even if it doesn't make it into cvs.


More information about the mythtv-dev mailing list