AW: [mythtv] Re: [PATCH] Add metadata editor to MythMusic

Flo Kohlert flokohlert at muenchen-mail.de
Thu Dec 30 14:27:44 UTC 2004


> Paul wrote:
> > Just noticed a discrepancy in MythMusic's dbcheck.cpp which updates
> > the database schema.
> >
> > At the top of the file currentDatabaseVersion is set to "1001" but at
> the
> > bottom of the file there is an update from version "1001" to "1002".
> >
> > Shouldn't the currentDatabaseVersion not be set to "1002"?
> >
> > If  I understand the code properly the update from version 1001 to 1002
> > will never take place. If that is the case the above patch will not work
> > because it uses the compilation field which is only available after the
> > update to 1002.
> >
> > Not sure why my database already contains the update. Possibly it was
> > updated
> > by the mfd stuff?
> 
> I can't really comment for why it's like that but I did notice it too.
> 
> I've added a field in my multiartist patch, but I've not yet submitted
> it as I'm still testing (the lazy way).
> 
> It is definatly to do with mfd, but I'm not sure the recommended
> practice will be.
> 
> Probably the best thing to do is to package up the dbcheck.cpp as best
> you can and alert Thor to it, as it'll probably be him that'll apply it.
> He can decide how best to number the schema... (I'm sure I asked about
> this ages ago and that was baiscally the answer given. I can't find it
> in my mail anymore, so probably archived away...)
> 
> Col.

This seems to break some things form e, with cvs of 12/29

g++ -c -pipe -Wall -W -O3 -march=pentiumpro -fomit-frame-pointer
-D_REENTRANT -fPIC  -D_GNU_SOURCE -DPREFIX=\"/usr\" -DQT_NO_DEBUG
-DQT_THREAD_SUPPORT -DQT_PLUGIN -DQT_SHARED -I/usr/share/qt3/mkspecs/default
-I. -I/usr/include -I/usr/include/cdda -I/usr/include/qt3
-I/usr/X11R6/include -o main.o main.cpp
In file included from playbackbox.h:15,
                 from main.cpp:18:
editmetadata.h:56: error: Syntaxfehler before `*' token
editmetadata.h:57: error: Syntaxfehler before `*' token
editmetadata.h:58: error: Syntaxfehler before `*' token
editmetadata.h:59: error: Syntaxfehler before `*' token
editmetadata.h:60: error: Syntaxfehler before `*' token
editmetadata.h:61: error: Syntaxfehler before `*' token
make[1]: *** [main.o] Fehler 1

thx

flo




More information about the mythtv-dev mailing list