[mythtv] [PATCH] Mythmusic not finding track length for .flac
ijr at case.edu
Thu Dec 30 02:12:07 UTC 2004
On Wednesday 29 December 2004 06:15 am, Colin Guthrie wrote:
> Wendy Seltzer wrote:
> > I think I've tracked down the problem here but don't have the C++
> > know-how to fix it:
> > Reading the track length of flac files appears to have broken in the big
> > Nov. 26 mythmusic patch. A rollback to CVS from Nov. 25 reads track
> > lengths again (and once they're in the db, they stay there). It looks
> > as though some of the code didn't make it from flacdecoder.cpp into
> > metaioflacvorbiscomment.cpp
> Bang on Wendy!
> I'd not really noticed the FLAC decoders correct identification of track
> length and thought it hadn't been implemented, but it's all there.
> A simple comment out of a line just before the Metadata constructor
> would have actually fixed it, but here is a more complete patch that
> sticks to the structure laid down by the metio base class. Not sure if
> it'll be needed in the future in this way, but it's probably wise to
> stick to it just in case.
More information about the mythtv-dev