[mythtv] SQL prepare / bindValue patch for mythtv

Isaac Richards ijr at case.edu
Thu Dec 9 01:39:11 UTC 2004


On Wednesday 08 December 2004 05:57 pm, David Härdeman wrote:
> On Wed, Dec 08, 2004 at 12:15:28AM -0500, Isaac Richards wrote:
> >I did see one problem in proglist.cpp:
> >-    viewList.remove(text);
> >-    viewTextList.remove(text);
> >+    viewList.remove(viewList[view]);
> >+    viewTextList.remove(viewList[view]);
> >
> >but I've fixed that in my local tree..
>
> No, it should be correct since the patch does this:
> -    QString text = viewList[view];
> a few lines earlier.

Yeah, but, if you remove an entry from a list, how can you access that list 
looking for the just removed value on the next line? =)

> Further, I found a few problems (order / table / columns set via
> bindValue which is not valid), I've changed it (including the one
> instance I reported in a separate mail) and made a new patch. It's at:
>
> http://www.hardeman.nu/~david/mythpatch/mythtv-libs-preparebindvalue3.patch
>
> If you already have the previous patch in your local tree, the
> differences between the v2 and v3 patches should be easily found
> (bindValue(":ORDER"...bindValue(":COLUMN...bindValue(":TABLE)

Allright, I'll spend the time to go through things..

Isaac


More information about the mythtv-dev mailing list