[Small PATCH as Req] + Re: [mythtv] frequent PlayBoxTransparency

Colin Guthrie myth at colin.guthr.ie
Fri Aug 20 04:30:32 EDT 2004

Chris Pinkham wrote:
>>Would some of the videos not be listed as "No Cover" and some as "San 
>>Visage" (sorry I don't actually know any French, but I'm sure you'll 
>>catch my drift).
>>Does this not mean that the Metadata::getCoverImage method /should/ 
>>check all possible translations of "None" and "No Cover" rather than 
>>just the current translation??
> If there is a problem with something like this, you should consider storing
> this the same as the "All Programs" and "Default" recording group settings.
> These 2 special cases are stored in English in the DB but translated onscreen
> so that the user always sees their own native language.

Yeah, this would work.

For what it's worth, I reckon the code would be simpler if you just 
store the coverfile as an empty string and to the language insertion at 
the display end (rather than passing the value in the db through tr()).

This makes checks to see if the coverfile is valid a little simpler (at 
the moment the code checks to see if the field is blank, ="None" or ="No 
Cover", which could just be simplified to a blank check.

If I get a nod of agreement from Mr Stanley, then I'll make this patch.



|     Colin Guthrie      |
|  myth at colin.guthr.ie   |
| http://colin.guthr.ie/ |

More information about the mythtv-dev mailing list