[Small PATCH as Req] + Re: [mythtv] frequent PlayBoxTransparency setting DB lookup in mythvideo

Colin Guthrie myth at colin.guthr.ie
Thu Aug 19 19:14:04 EDT 2004


J. Donavan Stanley wrote:
>> Also, attached is another patch for you as requested. Hope things are 
>> OK now. I've just kept to the >0 convension.
 >
 > This is in.

Thanks :) My first commited patch. It's not much, granted, but hopefully 
my big MythMusic patch will be finished and of patchable standard soon!

Just out of curiosity, you know the whole "None", "No Cover" thing, does 
the fact that a translation is involved not mess things up for people 
accessing the same database with different languaged frontends and 
potentially both runing the Video Manager or even just the Gallery 
independantly?

Would some of the videos not be listed as "No Cover" and some as "San 
Visage" (sorry I don't actually know any French, but I'm sure you'll 
catch my drift).

Does this not mean that the Metadata::getCoverImage method /should/ 
check all possible translations of "None" and "No Cover" rather than 
just the current translation??

This was the logic behind me leaving it blank to save all that hassle....

Just food for thought perhaps.

Col.

-- 

+------------------------+
|     Colin Guthrie      |
+------------------------+
|   myth at colin.guthr.ie  |
| http://colin.guthr.ie/ |
+------------------------+

I wouldn't touch the metric system with a 3.048 metre pole.


More information about the mythtv-dev mailing list