[mythtv] PATCH: Don't hilight the selection in an inactive list

Ben Levitt levittben at yahoo.com
Thu Apr 22 18:05:27 EDT 2004


This tiny patch makes lists not hilight the selected
item when they're inactive.  

I made this change so that, in Watch Recordings, when
the focus is in the left column (you are choosing a
show, not an episode of that show) the right hand
column (episodes) doesn't have an item hilighted.

In particular, this makes the Visor theme a lot more
usable.  But I like how Blue and GANT look with this
Patch too.

Are there other areas of myth or myth plugins that
would be hurt by this patch?  (Watch Recordings,
Delete Recordings, and Video List all work/look
nice...  I don't have mythmusic installed...)

Ben


	
		
__________________________________
Do you Yahoo!?
Yahoo! Photos: High-quality 4x6 digital prints for 25?
http://photos.yahoo.com/ph/print_splash
-------------- next part --------------
Index: libs/libmyth/uitypes.cpp
===================================================================
RCS file: /var/lib/mythcvs/mythtv/libs/libmyth/uitypes.cpp,v
retrieving revision 1.67
diff -u -r1.67 uitypes.cpp
--- libs/libmyth/uitypes.cpp	18 Apr 2004 02:00:00 -0000	1.67
+++ libs/libmyth/uitypes.cpp	22 Apr 2004 21:43:50 -0000
@@ -1051,10 +1051,12 @@
         QPoint fontdrop = tmpfont->shadowOffset;
 
         dr->setFont(tmpfont->face);
-        dr->drawPixmap(m_area.left() + m_selection_loc.x(),
-                       m_area.top() + m_selection_loc.y() + 
-                       (int)(m_current * m_selheight),
-                       m_selection);
+
+        if (m_active == true)
+            dr->drawPixmap(m_area.left() + m_selection_loc.x(),
+                           m_area.top() + m_selection_loc.y() + 
+                           (int)(m_current * m_selheight),
+                           m_selection);
 
         left = m_area.left();
         for (int j = 1; j <= m_columns; j++)


More information about the mythtv-dev mailing list