[mythtv] Patch: Mythweb recording schedules, tweak groupings
Kenneth Aafløy
ke-aa at frisurf.no
Thu Apr 8 22:46:59 EDT 2004
On Friday 09 April 2004 04:10, Chris Petersen wrote:
> > I'm sorry for those short hand posts, but why make the post from the root
> > of the source? As a maintainer you are supposed to read through the patch
> > anyways, and the info you need is in the top lines anyways?
>
> Yes, but I'm lazy and keep the patches in a directory one level in from
> the root.. don't like typing "patch -p0 < ../../patches/whatever" :)
>
> That, and on small stuff, especially from people like Ed, whose patches
> have always been fine, I usually just glance at the code for typos, and
> at the filename.
>
> But it really just breaks down to my being lazy and not extremely
> familiar with patch/diff.
Yeah, sure I have to familiarise myself with this fact. But really, the effort
made by by you compared to the author of the patch is rather small (or large,
depending on how you look at it). So I'm only suggesting a lower level of
remarks, when it comes to submitting patches like this. Also this applies
sort of to my replies to Thor's commits, when he hardly (if any) provides any
info about what actually got committed to CVS.
Again, I'm sorry about this, but I feel that some CVS standard is missing
amongst the MythTV developers!
--
Kenneth Aafløy
ke-aa at frisurf.no
More information about the mythtv-dev
mailing list