[mythtv] "Allow recording even if duplicate episode" is ignored?

[Geoffrey Hausheer]

On 24 Sep 2003 17:08:43 -0400, "Derek Atkins warlord-at-MIT.EDU
|mythtv/1.0-Allow|" <j0xjhlc9ur0t at sneakemail.com> said:
> Gregory McLean <gregm at gxsnmp.org> writes:
> 
> > One would _assume_ that the programs are duplicates if they match? To
> > me the above sounds like a duplicate. Both descriptions are empty and
> > the titles and subtitle are the same unless I'm missing some subtle
> > thing somewhere.
> 
> The problem is that because the description is empty it is not
> being treated like a duplicate.  The logic appears to be:
> 
>   a.title = b.title AND a.subtitle = b.subtitle AND a.description =
>   b.description
>   AND a.title != NULL AND a.subtitle != NULL AND a.description != NULL;
> 
> It's the last piece that is causing the "failure" -- the empty
> description.
Why go overboard with features and switches?  I'd say, don't add controls
where common-sense works just as well.  Why not submit a patch that fixes
the logic, and see if Isaac will accept it.

In fact here it is:

Index: scheduledrecording.cpp
===================================================================
RCS file: /var/lib/mythcvs/mythtv/libs/libmythtv/scheduledrecording.cpp,v
retrieving revision 1.43
diff -u -r1.43 scheduledrecording.cpp
--- scheduledrecording.cpp      18 Sep 2003 21:34:24 -0000      1.43
+++ scheduledrecording.cpp      24 Sep 2003 21:27:44 -0000
@@ -245,9 +245,12 @@
 "  ( "
 "    oldrecorded.title IS NOT NULL AND oldrecorded.title <> '' AND
 program.title = oldrecorded.title "
 "     AND "
-"    oldrecorded.subtitle IS NOT NULL AND oldrecorded.subtitle <> '' AND
program.subtitle = oldrecorded.subtitle "
+"    program.subtitle = oldrecorded.subtitle "
 "     AND "
-"    oldrecorded.description IS NOT NULL AND oldrecorded.description <>
'' AND program.description = oldrecorded.description"
+"    program.description = oldrecorded.description "
+"     AND "
+"    (oldrecorded.subtitle IS NOT NULL AND oldrecorded.subtitle <> '' OR
"
+"     oldrecorded.description IS NOT NULL AND oldrecorded.description <>
'') "
 "  ) "
 " LEFT JOIN recorded ON "
 "  ( "


.Geoff