[mythtv] 'recommendations' patch 3

[Kirby Vandivort]

> >I'm getting an error trying to apply this patch but don't see what
> >the problem is.  Maybe I'm too sleepy.  Did you hand-edit the patch
> >file or anything?  Here's what I'm seeing:
> >
> >$ patch -p0 < /home/cpinkham/download/mythtv/patches/tmp/recommend.patch 
> >patching file libs/libmythtv/dbcheck.cpp
> >Hunk #1 succeeded at 172 with fuzz 1 (offset 1 line).
> >patching file libs/libmythtv/libmythtv.pro
> >patching file libs/libmythtv/remoteutil.cpp
> >patching file libs/libmythtv/remoteutil.h
> >patching file libs/libmythtv/scheduledrecording.cpp
> >patching file libs/libmythtv/scheduledrecording.h
> >patching file programs/mythbackend/mainserver.cpp
> >patch: **** malformed patch at line 271: Index: 
> >programs/mythbackend/mainserver.h
> 
> Chris, I had the exact same error and a similar error with
> Kirby's earlier patch. I don't see what would confuse "patch"
> so I assumed it was an anomaly.
> 
> Anyway, I got around this by editing out the last hunk for
> mainserver.cpp which is the "HandleGetRecommendedRecordings"
> piece. The patch applied cleanly then I manually edited
> mainserver.cpp to add in HandleGetRecommendedRecordings.
> 
> Also, check out "patch --dry-run" for help with debugging.


You should have said something!  I was tweaking the patch file, not
realizing that the @@ lines contained a 'num lines changed' int.  I had
briefly wondered over the weekend how it knew that @@ was a patch command,
because I was thinking that it was looking for @@ as an indication of
the next hunk.  Ah well, now I know better.

-- 

Kirby Vandivort                      Theoretical and Computational Biophysics 
Email: kvandivo at ks.uiuc.edu          3051 Beckman Institute
http://www.ks.uiuc.edu/~kvandivo/    University of Illinois
Phone: (217) 244-5711                405 N. Mathews Ave
Fax  : (217) 244-6078                Urbana, IL  61801, USA