[mythtv] [PATCH] Denoise3D MMX support patch

Isaac Richards ijr at po.cwru.edu
Tue Oct 14 14:06:53 EDT 2003


On Tuesday 14 October 2003 07:20 am, Andrew Mahone wrote:
> I'm not quite up to inline assembly with GCC, so my code uses the builtin
> vector types and functions.  I've looked over the assembly output, and to
> my eye, it doesn't look like GCC generates terrible code.  For pre-3.1 GCC,
> removing the MMX_BUILTINS define in settings.pro and the -mmmx argument to
> gcc in filters/denoise3d/denoise3d.pro will allow it to compile without MMX
> support.  If somebody better with inline assembly wants to port these
> changes, the builtins are used inside addLineMMX and subLineMMX, and to
> call emms at the end of denoise3DFilterMMX.  I've split the defines for the
> builtins into a separate header file, mmx_builtins.h.

Have you seen the (fairly standard) mmx.h that's used elsewhere in the 
project?  libs/libavcodec/i386/mmx.h  It's fairly easy to use, and wouldn't 
require the MMX_BUILTINS define and the -mmmx in the denoise3d.pro file..

> This patch is bloated significantly by the fact that I've run indent on the
> source files, to clean up the different code styles between the stuff I
> wrote, the stuff I borrowed from linearblend, and the stuff I borrowed from
> mplayer.  I've bzipped it in case of message size limits.

I generally prefer 4 space indents to tabs..

Isaac


More information about the mythtv-dev mailing list