[mythtv] [PATCH] Use frame number as position map key

Jason Hoos jhoos at thwack.net
Sun Nov 30 18:56:35 EST 2003


> 
> 
> No... no it doesn't.  Try this one.  Third time's the charm?
> 
> -Doug
> ----
> 

Doug -

I was testing out the original version of this patch, and I came across
a segfault.  In the FindPosition method of AvFormatDecoder, you had a
couple of while loops like:

  while (m_positionMap[lower].pos > desired_value && lower >= 0)

and 

  while (m_positionMap[upper].pos > desired_value &&
         upper < (int)m_positionMap.size())

On my system, there were a few occasions where it tried to access
m_positionMap with a bad index before it did the bounds check, and
choked :(

Jason


P.S. Glad to hear the AC3 stuff works well on your system.  Out of
curiosity, what kind of soundcard are you using?  The nForce2 stuff on
my motherboard isn't working as well as I'd like it to, and I haven't
come up with a simple fix for it yet besides maybe using different
hardware...





More information about the mythtv-dev mailing list