[mythtv] [PATCH] cropping filter, + filterchains bugs

D Banerjee davatar at comcast.net
Sun Nov 16 02:11:30 EST 2003

I thought this would be easier then getting v4l2 hardware cropping working,
plus it will still work on cards that don't support it.

Basically it will only crop to macroblock snaps (16 pixels). This allows
sending pure black to the encoder without producing ugly macroblocks. Speed
is ~1700 fps and ~3000fps with MMX on a athlon 1300, using Andrew Mahone's
timing code; so mostly it produces a negative cpu hit because of the encoder
time it saves :)

Also some stuff is broken in the new filter chains. It seems that the filter
chain init is hooked in the wrong place, as it continuously reloads the
filters from disk. In fact while debugging I didn't need to restart anything
in order to test, but exiting mythtv after chaning the file on disk would
segfault both mythtv and mythbackend, and at other random times. I'm not
sure how this is happening. Many times when loading/unloading filters (i.e.
denoise3d as playback filter) it will also segfault the backend on unload,
sometimes I get an error from free() complaining of an invalid pointer.


-------------- next part --------------
A non-text attachment was scrubbed...
Name: crop.patch
Type: application/octet-stream
Size: 12126 bytes
Desc: not available
Url : http://mythtv.org/pipermail/mythtv-dev/attachments/20031116/797fa7a5/crop.obj

More information about the mythtv-dev mailing list