[mythtv] [PATCH] : small cleanup

[manu]

Le 10.11.2003 08:19:42, Kenneth Aafløy a écrit :
> On Mon, 2003-11-10 at 00:12, manu wrote:
> > 	Hi all,
> > this is my first patch for myth, tell me if I got it wrong.
> > The patch speaks for itself, it is trivial, it is against current
> cvs
> > file is libs/libmyth/audiooutputoss.cpp
> 
> This will cause some writes to go undetected. Are you experiencing
> problems without this patch? Try putting in a perror call within the
> if
> clause to see the real error instead.

Hmm, the idea here is just that this test is never true because the  
while clause has already a test with lw>0.

> > Next thing : in libs/libmyth/audiooutputalsa.cpp line 156 I think
> that
> > the calculation
> >  audio_bytes_per_sample = audio_channels * audio_bits / 8;
> > is wrong when audio_bits is different from 8 (which can occur if I
> read
> > correctly the following lines).
> 
> The /8 is to convert bits to bytes, audio_bits is the resolution of
> the
> audio, the calculation is correct.
>

Sorry for the dumb remark, I guess I should not work too late at  
night ;-)