[mythtv] [PATCH] More PVR-350 Commerial Stuff

Isaac Richards ijr at po.cwru.edu
Mon Nov 3 00:45:06 EST 2003


On Sunday 02 November 2003 04:59 am, Brett Lucey wrote:
> After tracing through a lot of the code, I found the original source of the
> NULLs into the commercial skipping code, when using a PVR350 for decoding. 
> It appears that when the commercial flagging has not yet run, and the
> player tries to do it "on the fly", the ivtv decoder basically just gets a
> NULL frame whenever the frame is requested, since the decoding is done in
> hardware.
>
> I have a patch that fixes this, but I have not yet finished testing it, and
> I will post it as soon as I have.  Does the above explanation make sense,
> or am I missing some way that Myth should be able to get the decoded frames
> from the PVR350?

What's wrong with just bailing out of the on the fly commercial detection like 
it is currently when it doesn't have the frame data to play with?

Isaac


More information about the mythtv-dev mailing list