[mythtv] [PATCH] MythMuisc segfault on no playlist

dan dan at milkcarton.com
Thu May 15 23:01:45 EDT 2003


Attached is a patch for mythmusic which fixes a segfault which occurs 
when you try to play music with no songs in the playlist.  This 
preticular bug would only occur if "List As Shuffled" was selected 
(Which tarek is why it more than likely didn't segfault for you).

-dan
-------------- next part --------------
Index: mythmusic/playbackbox.cpp
===================================================================
RCS file: /var/lib/mythcvs/mythmusic/mythmusic/playbackbox.cpp,v
retrieving revision 1.32
diff -u -d -r1.32 playbackbox.cpp
--- mythmusic/playbackbox.cpp	5 May 2003 19:26:01 -0000	1.32
+++ mythmusic/playbackbox.cpp	16 May 2003 05:39:37 -0000
@@ -719,12 +719,15 @@
 {
     int max = playlistorder.size();
 
-    for(int x = 0; x < max; x++)
-        listlist.at(playlistorder[x])->setText(0, QString::number(x));
+    if ( plist->count() )
+    {
+        for(int x = 0; x < max; x++)
+            listlist.at(playlistorder[x])->setText(0, QString::number(x));
 
-    playview->setSorting(0);
-    playview->sort();
-    jumpToItem(listlist.at(playlistorder[shuffleindex]));
+        playview->setSorting(0);
+        playview->sort();
+        jumpToItem(listlist.at(playlistorder[shuffleindex]));
+    }
 }
 
 void PlaybackBox::setupPlaylist(void)


More information about the mythtv-dev mailing list