[mythtv] Small code improvement.

Matt Zimmerman mdz at debian.org
Sun May 11 01:38:25 EDT 2003

On Sun, May 11, 2003 at 12:18:15PM +1000, michael at optusnet.com.au wrote:

> Would you object if I at least moved all the magic numbers to variable,
> and consolidated them in one place?
> I'm finding some areas of the code very difficult to understand.  Would
> you object to a patch to simplified some things, and added a bunch of
> comments?

Some of this code has gotten a bit tangled as it has grown.  I don't think
anyone would object to it being cleaned up, as long as:

- the behaviour doesn't change
- it really is simpler, and not just different or smaller.  This means that
  it is easier for everyone to understand, not just you

> In RingBuffer::safe_read(int,void*,int) when the read() gives EOF, why
> does it try another 20 times before failing? (I notice similar code in
> lots of other places).

Another thread is writing to the file, so it is growing longer.

 - mdz

More information about the mythtv-dev mailing list