[mythtv] (NEW) patch for mythVideo to use already scanned
coverfile
Kevin Elliott
kevin at phunc.com
Sat Jul 19 19:37:38 EDT 2003
On Sat, Jul 19, 2003 at 11:14:36AM -0400, Dave Alden wrote:
> Hi,
>
> On Fri, Jul 18, 2003 at 03:29:24PM -0400, James Y. Knight wrote:
> > Using dot files for that is gross. If you're worried about stat'ing
> > multiple files to find the one with the right extension, why not simply
> > make it people use an extension of ".cover" no matter what the file
> > format the image is.
> > aka "the rookie.avi.cover".
>
> The only problem with this is that I'd have to modify mythvideo to ignore
> files that end in ".cover" -- I'm not comfortable with doing that (what if
> someone named their movie "duck.and.cover" :-).
>
> Since no one else spoke up, I've gone with the dotfile approach. All you
> need to do is to put the coverfile in the same directory as the movie and
> call it ".<moviefilename>". The patch is attached. :-)
>
> ...dave
As someone mentioned before, using dot files for this purpose is
almost irresponsible. Why didn't someone just write some functionality
to check what kind of file it is, and put that in? It needs that anyways.
As it is, MythVideo shows files that are sitting in the same dir as
videos. And they obviously can't be played. There should be a match
list of acceptable files for videos, and another for covers.
Second, naming an image file ".Terminator.avi" seems beyond silly to
me. Not only is that misusing dot files, but you've removed any identification
of it being an image file from the filename.
Kevin
More information about the mythtv-dev
mailing list