[mythtv] Status of VBR MP3 length determination?

[thor]

On Wednesday 16 July 2003 08:56 pm, Joseph A. Caputo wrote:
> Is VBR MP3 length determination completely broken now in Mythmusic? 

	Works fine here, but obviously not working in all cases.


	I had four promises to submit code to improve the VBR calculations (two on 
the mailing list and two in IRC). Have yet to receive anything.


> my VBR mp3s have their lengths computed as 835, which works out to 00:00.
> I'm attempting to delve into the code to make it so that VBR MP3s

	On the scanning side, you probably just want to drastically simplify the 
stuff in maddecoder.cpp in getMetada(). Have a look at the while loop defined 
over loop_de_doo.

	On the playing side, you just want a check in play() (in playbackbox.cpp) 
that looks at the time for an mp3 and guesses whether it's really of length 
0. At that point, you can calculate the length.

	Of course, if you right good code to calculate the length, it should probably 
go back into maddecoder.cpp .... at least as an option to the user (calculate 
lenght on scan or first play).

- thor