[mythtv] [PATCH] V4L picture controls use same interface as Xv

[jcaputo1 at comcast.net]

> --- "Joseph A. Caputo" <jcaputo1 at comcast.net> wrote:
> > The attached patch makes the V4L picture controls
> > (Contrast, Brightness, 
> > Color, Hue) use the same UI as the Xv picture
> > controls (i.e., a single key 
> > toggles through the 4 attributes, with LEFT and
> > RIGHT changing the selected 
> > setting).  Not only does it make the UI more
> > consistent, but it eliminates 
> > the current 8 keybindings for these controls and
> > replaces them with just 1 
> > (F1).
> > 
> > I tested it on my box; feel free to tweak the
> > strings in the OSD and the 
> > default keybinding.
> > 
> > -JAC
> 
> I think you need to create a new kOSDFunctionalType
> like kOSDFunctionalType_RecPictureAdjust in osd.h. 
> Then always call osd->StartPause() with your new
> kOSDFunctionalType.  Then add a couple lines to
> TV::HandleOSDClosed() in tv_play.cpp like the lines
> for 
> kOSDFunctionalType_PictureAdjust.
> 
> The idea is that when you call osd->StartPause(), you
> tell it what purpose the pause box is being used for. 
> Then when the pause box closes (or gets used for
> something else), it sends back notification that it
> closed.  This way, in the tv_play code, we can change
> back from using Left/Right to adjust picture controls
> to using them for skipping forward/back.  Search for
> kOSDFunctionalType_PictureAdjust to see where and how
> it's used.
> 
> That should do it.  
> 
> Ben

Thanks... actually, what I ended up doing was just re-using the kOSDFunctionalType_PictureAdjust type, since it's essentially the same purpose.  That seemed to do the trick.  If I have time I might split it off into its own type, but it seemed to make sense to have these two functions share as much code as possible.  There are still a few more tweaks I need to make, but I can't work on it now until I get home, as I'm at work, the patch is at home, and I fubar'ed my firewall last night so I can't tunnel back there right now.

-JAC

PS- Sorry if this post shows up in HTML or something else weird.  Since I lost my SSH-tunnel for the day, I've had to resort to using webmail.