[mythtv] [PATCH] Re: policy on using 'VERBOSE' in myth

Geoffrey Hausheer ou401cru02 at sneakemail.com
Wed Aug 27 17:23:46 EDT 2003

On Sun, 24 Aug 2003 20:22:52 -0500, "Geoffrey Hausheer
ou401cru02-at-sneakemail.com |mythtv/1.0-Allow|"
<khm9hhqgzu0t at sneakemail.com> said:
> On Sun, 24 Aug 2003 21:05:59 -0400, "Isaac Richards ijr-at-po.cwru.edu
> |mythtv/1.0-Allow|" <e6kbhbk35r0t at sneakemail.com> said:
> > 
> > This looks fine to me, but you've only got:
> > 
> > enum VerboseMask {
> >     VB_GENERAL  = 0x01,
> >     VB_RECORD   = 0x02,
> >     VB_PLAYBACK = 0x04,
> >     VB_CHANNEL  = 0x08,
> >     VB_NONE     = 0x00,
> >     VB_ALL      = 0xff
> > };
> > 
> > in the patch, not what you described?
> Sorry, that was a earlier incantation of the patch (and it won't even
> come close to compiling cleanly.
> here is the right version.

    Thanks for applying this.  I noticed that you skipped some parts of
    the patch, which is cool, but was specifically currious abut this one
    in RingBuffer.cpp:

    while (count > BufFree())
        if (first)
            cerr << "IOBOUND - blocking in
        first = 0;
This isn't really an error (it may or may not generate loss of data).  So
I'm not sure why we want to report this by default.  Checking in the
encoder if this is causing real data loss would be the right place for an
error message, it seems to me.  specifically, I get this all the time
using the transcoder, since I can effectively feed it data at the same
rate that I read it, and blocking the write has no impact on the
output....This is why I had changed it to an info message with a 
'verbose' in my patch.  I'm cool with another solution, but I'd rather
not generate lots of these messages while transcoding.  Comments?


More information about the mythtv-dev mailing list