[mythtv] [PATCH] Fix for mythmusic ripped genre

Isaac Richards ijr at po.cwru.edu
Fri Aug 22 23:39:47 EDT 2003

On Friday 22 August 2003 09:40 pm, Joseph A. Caputo wrote:
> OK, so my previous patch to allow you to change the genre of a ripped CD
> didn't exactly work... that is, it would allow you to change the genre on
> the combo box, but the updated genre didn't get saved in the ID tag, and it
> also used the original genre as the director (if you had that option on).
> The problem is that 'genre' in the CDDA disc info structure, unlike album &
> artist, is only an enum with very few possible values.  There's a
> cddb_genre() function to get the genre text by doing a lookup.  This
> obviously does not support custom genre names you might have (not to
> mention the fact that the CDDecoder class doesn't even *try* to save the
> genre back to the structure.  Makes sense, though).  So, what this patch
> does is when the disc info structure gets read back in in the ripTheDisc()
> function, it overrides the detected genre with the one from the combo box
> and uses that for the directory, as well as passing it to the encoder. 
> Consider this very low risk :-)

Thanks, just committed this.


More information about the mythtv-dev mailing list