[mythtv] Trick play patch
ijr at po.cwru.edu
Wed Aug 20 11:24:17 EDT 2003
On Tuesday 19 August 2003 11:10 pm, David Engel wrote:
> Here is the patch. frame_interval is now set whenever play_speed is
> changed. That, along with a new normal_speed boolean removes all
> floating point from the critical path.
I'll get this applied, thanks..
> On Tue, Aug 19, 2003 at 08:42:00PM -0400, Isaac Richards wrote:
> > On Tuesday 19 August 2003 08:28 pm, David Engel wrote:
> > > The patch for that is below. It also fixes a compiler warning.
> > Do you think you could move that logic into tv_play.cpp? I'm worried
> > about side effects if it's in NVP..
> Sure, if you'll tell me how. :) The obvious approach won't work from
> TV because of threading. That leaves things like synchronizing the TV
> and NVP threads (not very desirable) or having a timer in TV reset
> exact seeks (pretty kludge, IMHO).
Yeah, couldn't think of an easy way, either -- and the patch as is breaks
seeking to the nearest keyframe in edit mode.
> Of course, we could just punt and tell users who want exact single
> frame rewinds that they need to turn on exact seeks.
That's probably the best way to do it..
> It's more complicated than that. The fade movement needs to be
> adjusted somehow too.
Ah, yeah.. Hmm..
More information about the mythtv-dev