[mythtv] Trick play patch

Isaac Richards ijr at po.cwru.edu
Tue Aug 19 21:42:00 EDT 2003

On Tuesday 19 August 2003 08:28 pm, David Engel wrote:
> On Tue, Aug 19, 2003 at 01:31:15PM -0400, Isaac Richards wrote:
> > > do exact seeks for single frame increments.  I just tested this and it
> > > works fine.  Should exact seeks also be done for 1 second increments?
> >
> > Exact seeking is rather slow, but if it's only done (while the 'exact
> > seeks' option is turned off) while paused, that's fine.
> The patch for that is below.  It also fixes a compiler warning.

Do you think you could move that logic into tv_play.cpp?  I'm worried about 
side effects if it's in NVP..

> Great.  I'll take a look at this myself later tonight.  My intent was
> to get it working right first, then worry about any optimizations.
> One thing I didn't get entirely right though was the OSD.  The fade
> speed is too fast or slow if the play speed isn't 1x.  Do you have any
> suggestions for an acceptable fix?  It's not a high priority, but I'd
> still like to fix it.

I think it's that the SetFPS function needs to propogate the fps value to the 
'totalfadeframes' variable is all.


More information about the mythtv-dev mailing list