[mythtv] [PATCH] Massive LCD Support Update
dan at milkcarton.com
Mon Aug 18 15:53:36 EDT 2003
Isaac Richards wrote:
> On Monday 18 August 2003 06:13 pm, DanM wrote:
> > I matched the indentation in lcddevice.* per the recomendation, I
> > presume you changed it from using tab to using spaces? What bug
> > did you fix in themedmenu? I'll do a clean checkout tonight and
> > make sure everything still works fine.
> Yeah, I got tired of the existing indentation style in there while I
> was applying your patch, so I fixed it to be the One True Indentation
> Style. Bug in themedmenu was you were assuming all rows had the same
> number of columes. Just a minor little thing, really. Oh, and I
> should mention that I didn't end up using the additional lcd*.cpp
> files -- I just incorporated them into the lcddevice header, as the
> two classes were just simple data types.
I did notice that you incorporated them into the same file, no biggie.
I may break them back out when I do the rewrite, I haven't figured out
if I'm going to just serialize the data and send it down the wire, or do
something else. Don't know yet.
> > My future plans for this is make the LCD stuff into a daemon and
> > make lcddevice connect to the socket , so there isn't any
> > contention between say MTD holding the display, preventing
> > mythfrontend from updating it; mythbackend can turn on a LED or 3
> > when something important happens (Say it start recording). Does
> > all this sound fine? Or do you have a suggestion as to a better
> > way of doing this?
> That sounds fine to me, but as I don't have a LCD display, I'm rather
> ambivalent about it all =)
Works for me :-)
More information about the mythtv-dev