[mythtv] MythChannels droped.

Ben Bucksch linux.news at bucksch.org
Mon Aug 18 23:18:20 EDT 2003

Ramon Roca wrote:

>-It takes to me more than 30 minutes to figure out how to put all pids
>together in a single column being able to distingish them
I didn't ask that.

What I asked for is 2 lines of code, really (and I said so):

Your patch:
-                  " pids "
+                  " vpids, apids "
-    option = query.value(13).toString();
+    // Currently video/audio pids are being parsed at SetPID  being splited
+    // by ','... we'll see how will that be done in the future...
+    option = query.value(13).toString()+","+query.value(14).toString();

What I asked for instead:
-                  " pids "
+                  " pids_vid, pids_aud, pids_ac3, pids_teletext, 
pids_subtitle, pids_other "
-    option = query.value(13).toString();
+    option = query.value(13).toString()+","+query.value(14).toString()

*This* is all that's needed for the "you must record all PID types" 
part, what we discussed for 2-3 hours!

>-It takes more than 15/30 minutes to rename a table/column and then review mythchannels 7,000 lines of code to change all the places where it was used without introducing new bugs.
grep or any other search function? It can't be that hard to replace 
"tpid" with "pids_teletext".

As for the names:

    * What is better? adpid or pids_ac3? I think the answer is clear.
    * Can we change it later? We can, but it's much harder, because
      users will already be using it. And, if you don't want to change
      it now, why would you do it later?
    * Is it important? Yes, I think so, because I think that it's bad to
      have to look up a definition for a field (which you didn't even
      submit!), if its meaning could be obvious from the name.

I hope you see it's not unreasonable what I ask from you, but increases 
code quality.

You're basically throwing some code at us "take it or leave it". You're 
not willing to change anything *at all*. This isn't how it works.

>I'm sure that will be better programmers looking for a boss who will be very disciplinated doing what you want for free.
You should really try to get something into Mozilla or the Linux kernel. 
With Mozilla, you can be happy, if somebody cares about your patch at all.
And I really did care about your patch, I spent several hours to discuss 
it with you, although I really didn't want to.

Anyways, don't let that spoil your vacation mood. It's just software :).


More information about the mythtv-dev mailing list