[mythtv] host patch: mythmkmovie 1.0rc2

John M Wright myth at wakamole.homeip.net
Sat Aug 2 01:18:10 EDT 2003

I don't know what I was doing the night I submitted this
patch, but it's got two errors in it.  Micheal already included 
my patch in mythmkmovie v1.0, fixing one error (incorrect use
of chomp) but not catching the other.  It's a minor change, so
I'll just put it inline:

--- mkmovie.preconf.real        2003-08-02 00:16:56.000000000 -0500
+++ mkmovie.preconf     2003-08-02 00:17:07.000000000 -0500
@@ -1422,7 +1422,7 @@

        $dbh = connectToDB($mythconf);
-       ($vidcapdir) = $dbh->selectrow_array('select data from settings where value="RecordFilePrefix" and host = "' .
+       ($vidcapdir) = $dbh->selectrow_array('select data from settings where value="RecordFilePrefix" and hostname = "' .
                $host . '"');
        chdir($vidcapdir) or die ("ERROR! Unable to change to directory $vidcapdir!\n");

~John M Wright

On Wednesday 23 July 2003 09:43 pm, John M Wright wrote:
> Michael:
> I have attached a patch to your mythmkmovie script.
> The patch does the following:
> - when determining the RecordFilePrefix, it first
>   executes the `hostname` command and uses that
>   as the 'host' field in the query.
> Reasoning:
> I have two different systems, each with it's own (different)
> RecordFilePrefix entry in the settings table.  Without including
> the 'host' in the sql query, mkmovie uses the first value returned.
> In my case, the path returned was for the wrong system and
> caused mkmovie to fail.
> Note:
> I'm not sure how mythtv determines the value of the 'host'
> field when populating the settings table. I _assumed_ it
> used the /etc/hostname file or equivalent, which is what
> is returned by the `hostname` command.  I _assumed_ the
> `hostname` command what in the PATH (ie: did not include
> a full path to the binary).  Feel free to improve on this :-)
> I am just starting to play with the mkmovie/transcode, etc
> stuff in mythtv, but so far enjoy the program (although
> I'm having some unrelated problems compiling mplayer).
> Let me know if you have any questions.
> Thanks
> ~John

More information about the mythtv-dev mailing list