[mythtv] [PATCH] Display ChanNum in BrowseMode

[Dan M]

Heres a patch to put ChanNum up when in browse mode.

-dan


Dan M wrote:

> Chris, I tracked down the channel 11 problem.  It shows up as Unknown 
> (Gotta track that down).  I'll try to write a patch to your mod which 
> accounts for this.  The QDate and QTime errors are related to this 
> issue as well.
>
> Regarding the channel number thing, I used channelname from your piece 
> and modified a few line to come up with this:
>    if (oset)
>    {
>        osd->SetVisible(oset, 0);
>        osd->SetChannumText(channelname, 999);
>    }
>
> and a corresponding     osd->HideSet("channel_number"); in BrowseEnd 
> works just fine. 
> -dan
>
> Chris Pinkham wrote:
>
>> Does channel 11 have any data in the database?  This seems like the
>> exact same problem I experienced during testing when I had a channel in
>> my channels table that did not have any corresponding data in the
>> programs table (ie, I had commented out that channel in my xmltv channel
>> list config file).  If you do have programs in the program table for
>> channel 11, can you check and see if there's anything odd about them 
>> like
>> for instance it's a local news-only channel with 3-4 program listings 
>> per
>> day that last 6 hours each or something weird like that.  I tested by
>> going all the way through my channel list and was able to cycle through
>> every channel even examples like the all-news channel I mentioned.
>>
>> Also, on the channel number item. This would involve a patch to 
>> tv_play.cpp
>> as well as modifying every OSD theme.  The channel number is already
>> retrieved as part of my code, but the OSD::SetInfoText() does not 
>> display
>> it and there's no place in the OSD theme yet.
>>  
>>
>>> I haven't noticed the issue you have but I have noticed a couple of 
>>> things.
>>>
>>> If I start above channel 11 (Don't know if its an arbitriary value, 
>>> or something mucked up with my data), when I hit 'O' I can scroll 
>>> through channels above it, but not below it.  If I start below chan 
>>> 11, I can browse through channels below it, but not above it.
>>>
>>> I also see a bunch of QDate errors on the console:
>>> QDate::setYMD: Invalid date 2003/42/18
>>> QTime::setHMS Invalid time 50:00:00.000
>>>
>>> I'm working on a mod for this feature to display the channel number 
>>> along with the rest of the info.  When I get done with this, I might 
>>> look into the rest of the issues
>>>
>>> -dan
>>>
>>>
>>> ben wrote:
>>>
>>>   
>>>
>>>> When you press 'O'  The browse screen show up with the correct
>>>> information for the current channel.  When you hit the up, down, left,
>>>> or right keys, the screen changes and all the information is 
>>>> replaced by
>>>> 'Ok'
>>>>
>>>> Ben
>>>>
>>>> -----Original Message-----
>>>> From: mythtv-dev-bounces at snowman.net
>>>> [mailto:mythtv-dev-bounces at snowman.net] On Behalf Of Chris Pinkham
>>>> Sent: Sunday, April 20, 2003 6:35 PM
>>>> To: mythtv-dev at snowman.net
>>>> Subject: Re: [mythtv] New 'O' option only displays OK
>>>>
>>>>
>>>>
>>>>
>>>>     
>>>>
>>>>> The new OSD 'O' option only displays Ok when I try to browse channels.
>>>>>  
>>>>>       
>>>>
>>>> Huh?
>>>>
>>>> 'O' turns on the browse option.  If it only displays Ok when you try to
>>>> browse channels when does it not display Ok and what is it doing?
>>>>
>>>> Chris
>>>>
>>>> ************************************************************************
>>>> *****
>>>> ** Chris Pinkham                  Linux v2.2.18, Sane v1.0.4, Cajun
>>>> v3.0-8 **
>>>> ** cpinkham at bc2va.org
>>>> http://www.bc2va.org/chris/ **
>>>> ************************************************************************
>>>> *****
>>>> _______________________________________________
>>>> mythtv-dev mailing list
>>>> mythtv-dev at snowman.net
>>>> http://lists.snowman.net/cgi-bin/mailman/listinfo/mythtv-dev
>>>>
>>>> _______________________________________________
>>>> mythtv-dev mailing list
>>>> mythtv-dev at snowman.net
>>>> http://lists.snowman.net/cgi-bin/mailman/listinfo/mythtv-dev
>>>>
>>>>
>>>>     
>>>
>>> _______________________________________________
>>> mythtv-dev mailing list
>>> mythtv-dev at snowman.net
>>> http://lists.snowman.net/cgi-bin/mailman/listinfo/mythtv-dev
>>>
>>>   
>>
>>
>>
>>  
>>
>
> _______________________________________________
> mythtv-dev mailing list
> mythtv-dev at snowman.net
> http://lists.snowman.net/cgi-bin/mailman/listinfo/mythtv-dev

-------------- next part --------------
Index: libs/libmythtv/tv_play.cpp
===================================================================
RCS file: /var/lib/cvs/MC/libs/libmythtv/tv_play.cpp,v
retrieving revision 1.51
diff -u -d -r1.51 tv_play.cpp
--- libs/libmythtv/tv_play.cpp	20 Apr 2003 22:12:05 -0000	1.51
+++ libs/libmythtv/tv_play.cpp	21 Apr 2003 06:46:11 -0000
@@ -1933,6 +1933,7 @@
 void TV::BrowseEnd(bool change)
 {
     osd->HideSet("program_info");
+    osd->HideSet("channel_number");

     if (change)
     {
@@ -1985,6 +1986,9 @@

     oset = osd->GetSet("program_info");
     if (oset)
+    {
         osd->SetVisible(oset, 0);
+        osd->SetChannumText(channelname, 999);
+    }
 }