[mythtv] [PATCH] Add transcoding support (final)
ijr at po.cwru.edu
Sun Apr 20 11:30:17 EDT 2003
On Sunday 20 April 2003 09:59 am, Geoffrey Hausheer wrote:
> a couple things about the transcoding stuff you merged.
> 1) This line needs to be added in NuppelVideoPlayer::AddTextData around
> line 781:
> txtlen[wtxt] = len;
I'm planning to consolidate all those txt* vectors to a single struct.
> 2) You may want to remove the ForceChannel stuff in channel.cpp and
> channel.h, that just snuck into my patch. My AverTV card doesn't seem to
> tune correctly if initialized to the current channel, so I need to force
> an up-1, down-1 to get it synced. My patch didn't include the actual
> call to ForceChannel, but I forgot to remove the function when I made the
It did include a call to it, I just left it out, with the intention of asking
what it was for =)
> 3) In Transcoder::InitTranscoder in transcoder.cpp around line 289, the
> transcoder still saves the original file as .nuv.old instead of removing
> it. I left that there on purpose, since the transcoder may still be
> buggy, and people may not want to lose their files, but I thought I'd
> bring it up in case you want to revert to the original 'replace the old
> file with the new one' (in which case just remove the rename, and
> uncomment the unlink)
I'll probably do that..
> 4) You seem to run some sort of code formatter on your code. Could you
> tell me what it is, so I can make cleaner patches?
It's called 'applying by hand' =). 4 space indents, braces on their own line,
no spaces after/before ( )s..
> 5) I noticed you didn't include the control to enable the transcoders in
> mythfrontend (or the cvs.sql). I'm just curious why not.
I need to talk with mdz 'bout stealing profile 3 like that -- I, at least,
already have that number used by something else. I'll hook up the UI bits
later, as well.
More information about the mythtv-dev