[mythtv] [PATCH] - [BUG] mythfrontend - Delete Recording

dan dan at milkcarton.com
Sat Apr 5 21:25:47 EST 2003


I presume your refering to the patch line which begins with:
if (showData.count() == 0)
{
- tmp.drawText(showTitleLeft, (int)((double)bgShowPixmap->height() / 
(double)2) - showingHeight,

Thats the only part I could see which was extrenious.  If so, I did not 
make any changes to that part.  I don't know how/why it generated that 
snippet.  Not knowing how it would affect things if I edited the diff 
file, so I left it in there.


What changes would you like me to make to get this patch committed?

-dan

Isaac Richards wrote:

>On Saturday 05 April 2003 10:33 pm, dan wrote:
>  
>
>>When in the delete recording screen, I had one recording listed.  I
>>pressed space to bring up the popup widget and deleted it.  Now the box
>>says "Sorry, No Recordings Available".  That part works fantastic.
>> However, if I press space again, the popup will display the info of the
>>last item deleted.  I've created a patch to address this issue.
>>
>>Info on patch:
>>  In PlaybackBox::selected() change remove(curitem) to use the
>>deleteSelected method so logic only has to be done in one place.  in
>>deleteSelected check that showData.count() has count != 0 before calling
>>the remove method.
>>    
>>
>
>When you're submitting a patch, please don't include completely extraneous 
>changes in it.
>
>Isaac
>_______________________________________________
>mythtv-dev mailing list
>mythtv-dev at snowman.net
>http://lists.snowman.net/cgi-bin/mailman/listinfo/mythtv-dev
>  
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: /pipermail/attachments/20030405/f3c290af/attachment.htm


More information about the mythtv-dev mailing list