[mythtv-commits] [MythTV/mythtv] 044b15: PortChecker::checkPort(): Reduce scope of a variable

Fri Jan 23 20:53:50 UTC 2026

  Branch: refs/heads/master
  Home:   https://github.com/MythTV/mythtv
  Commit: 044b15c73ea461e61c4940626be5829eedae7c67
      https://github.com/MythTV/mythtv/commit/044b15c73ea461e61c4940626be5829eedae7c67
  Author: Scott Theisen <scott.the.elm at gmail.com>
  Date:   2026-01-23 (Fri, 23 Jan 2026)

  Changed paths:
    M mythtv/libs/libmythbase/portchecker.cpp

  Log Message:
  -----------
  PortChecker::checkPort(): Reduce scope of a variable

  Commit: 60c182a8580b9805fb494d58d7c4a7868bd29f41
      https://github.com/MythTV/mythtv/commit/60c182a8580b9805fb494d58d7c4a7868bd29f41
  Author: Scott Theisen <scott.the.elm at gmail.com>
  Date:   2026-01-23 (Fri, 23 Jan 2026)

  Changed paths:
    M mythtv/libs/libmythbase/mythdbcon.cpp
    M mythtv/libs/libmythbase/mythdownloadmanager.cpp
    M mythtv/libs/libmythbase/mythsocket.cpp
    M mythtv/libs/libmythbase/portchecker.cpp
    M mythtv/libs/libmythbase/portchecker.h

  Log Message:
  -----------
  PortChecker: Copy body of checkPort() into resolveLinkLocal()

  Commit: 98000d47c98c0be40e4d4402d265c30af1d68ce3
      https://github.com/MythTV/mythtv/commit/98000d47c98c0be40e4d4402d265c30af1d68ce3
  Author: Scott Theisen <scott.the.elm at gmail.com>
  Date:   2026-01-23 (Fri, 23 Jan 2026)

  Changed paths:
    M mythtv/libs/libmythbase/portchecker.cpp

  Log Message:
  -----------
  PortChecker: Remove now constant linkLocalOnly

  Commit: 9e2d036e403373b3a6dd04ef9d8da6fa473880f6
      https://github.com/MythTV/mythtv/commit/9e2d036e403373b3a6dd04ef9d8da6fa473880f6
  Author: Scott Theisen <scott.the.elm at gmail.com>
  Date:   2026-01-23 (Fri, 23 Jan 2026)

  Changed paths:
    M mythtv/libs/libmythbase/portchecker.cpp

  Log Message:
  -----------
  PortChecker::resolveLinkLocal() always returns false on Windows

  Commit: 46882ec1d6a917e7ed969afcb9caad083e63de50
      https://github.com/MythTV/mythtv/commit/46882ec1d6a917e7ed969afcb9caad083e63de50
  Author: Scott Theisen <scott.the.elm at gmail.com>
  Date:   2026-01-23 (Fri, 23 Jan 2026)

  Changed paths:
    M mythtv/libs/libmythbase/portchecker.cpp

  Log Message:
  -----------
  PortChecker::resolveLinkLocal(): Fix indent

  Commit: 8acea6130ea405f4a85428f3fae261dfaa5a2c38
      https://github.com/MythTV/mythtv/commit/8acea6130ea405f4a85428f3fae261dfaa5a2c38
  Author: Scott Theisen <scott.the.elm at gmail.com>
  Date:   2026-01-23 (Fri, 23 Jan 2026)

  Changed paths:
    M mythtv/libs/libmythbase/portchecker.cpp

  Log Message:
  -----------
  PortChecker::cancelPortCheck(): Add log message

  Commit: 642778f37a3acfdd9c07f54c9dc438f27fa3682d
      https://github.com/MythTV/mythtv/commit/642778f37a3acfdd9c07f54c9dc438f27fa3682d
  Author: Scott Theisen <scott.the.elm at gmail.com>
  Date:   2026-01-23 (Fri, 23 Jan 2026)

  Changed paths:
    M mythtv/libs/libmythbase/portchecker.cpp

  Log Message:
  -----------
  PortChecker::checkPort(): Call resolveLinkLocal()

when islinkLocal is true.

The only difference is that it may return earlier due to testedAll.

  Commit: b9f7598fc8fcbb30cae318d5e24191f690ff2003
      https://github.com/MythTV/mythtv/commit/b9f7598fc8fcbb30cae318d5e24191f690ff2003
  Author: Scott Theisen <scott.the.elm at gmail.com>
  Date:   2026-01-23 (Fri, 23 Jan 2026)

  Changed paths:
    M mythtv/libs/libmyth/mythcontext.cpp
    M mythtv/libs/libmythbase/portchecker.cpp
    M mythtv/libs/libmythbase/portchecker.h

  Log Message:
  -----------
  PortChecker::checkPort(): Don't modify parameters

Instead of having checkPort() modify the host parameter, call
resolveLinkLocal() explicitly to modify it.

This potentially modified parameter was only used after one call
to checkPort().

The call to resolveLinkLocal() should immediately return without
checking the port, using the cached scope or returning false,
since the st_dbStarted case can only be entered by fallthrough
and the previous case calls checkPort().

  Commit: bdff1b0a28832357f4de61675eedbd87f78cb61e
      https://github.com/MythTV/mythtv/commit/bdff1b0a28832357f4de61675eedbd87f78cb61e
  Author: Scott Theisen <scott.the.elm at gmail.com>
  Date:   2026-01-23 (Fri, 23 Jan 2026)

  Changed paths:
    M mythtv/libs/libmythbase/portchecker.cpp

  Log Message:
  -----------
  PortChecker::resolveLinkLocal(): Remove always true boolean tests

islinkLocal and isIPAddress will always be true in the loop, since
the function would have returned false otherwise.

  Commit: 3cf11643c655195dfe2740487b78cb0c2b233ce5
      https://github.com/MythTV/mythtv/commit/3cf11643c655195dfe2740487b78cb0c2b233ce5
  Author: Scott Theisen <scott.the.elm at gmail.com>
  Date:   2026-01-23 (Fri, 23 Jan 2026)

  Changed paths:
    M mythtv/libs/libmythbase/portchecker.cpp

  Log Message:
  -----------
  PortChecker::checkPort(): Reduce blocking time

  Commit: 5d02dcfe46c201e45217e4f6fc1775e0aee695a2
      https://github.com/MythTV/mythtv/commit/5d02dcfe46c201e45217e4f6fc1775e0aee695a2
  Author: Scott Theisen <scott.the.elm at gmail.com>
  Date:   2026-01-23 (Fri, 23 Jan 2026)

  Changed paths:
    M mythtv/libs/libmythbase/portchecker.cpp
    M mythtv/libs/libmythbase/portchecker.h

  Log Message:
  -----------
  PortChecker::resolveLinkLocal(): Reduce blocking time

  Commit: b85319e0e0c29f08856b65ffe61858c48c099f62
      https://github.com/MythTV/mythtv/commit/b85319e0e0c29f08856b65ffe61858c48c099f62
  Author: Scott Theisen <scott.the.elm at gmail.com>
  Date:   2026-01-23 (Fri, 23 Jan 2026)

  Changed paths:
    M mythtv/libs/libmythbase/portchecker.cpp

  Log Message:
  -----------
  PortChecker: Only processEvents() in the UI thread

  Commit: 4b85cbc10bc1d8b4ecd6541e70982d0d5ac18b39
      https://github.com/MythTV/mythtv/commit/4b85cbc10bc1d8b4ecd6541e70982d0d5ac18b39
  Author: Scott Theisen <scott.the.elm at gmail.com>
  Date:   2026-01-23 (Fri, 23 Jan 2026)

  Changed paths:
    M mythtv/libs/libmythupnp/ssdp.cpp
    M mythtv/libs/libmythupnp/upnptasknotify.cpp
    M mythtv/libs/libmythupnp/upnptasksearch.cpp

  Log Message:
  -----------
  SSDP: Log sent datagrams

  Commit: 51e8d194820c2b8561971111980285ad05113d4a
      https://github.com/MythTV/mythtv/commit/51e8d194820c2b8561971111980285ad05113d4a
  Author: Scott Theisen <scott.the.elm at gmail.com>
  Date:   2026-01-23 (Fri, 23 Jan 2026)

  Changed paths:
    M mythtv/libs/libmythupnp/upnptasknotify.cpp

  Log Message:
  -----------
  Don't send SSDP notify datagrams with loopback addresses

The address is incorrect for any host but the sender and will
cause PortChecker to timeout trying to connect to an nonexistent
service.

  Commit: 5bd880e7302e437ec7a3bb4cc68490e985d1c85d
      https://github.com/MythTV/mythtv/commit/5bd880e7302e437ec7a3bb4cc68490e985d1c85d
  Author: Scott Theisen <scott.the.elm at gmail.com>
  Date:   2026-01-23 (Fri, 23 Jan 2026)

  Changed paths:
    M mythtv/libs/libmythupnp/ssdp.cpp
    M mythtv/libs/libmythupnp/ssdp.h

  Log Message:
  -----------
  SSDP: Process received datagrams in a separate thread

Compare: https://github.com/MythTV/mythtv/compare/1e602dc6d21b...5bd880e7302e

To unsubscribe from these emails, change your notification settings at https://github.com/MythTV/mythtv/settings/notifications