[mythtv-commits] [MythTV/mythtv] b1bb52: Close file leak in PulseAudio output handler (#1098)

[Steve Erlenborn]

  Branch: refs/heads/master
  Home:   https://github.com/MythTV/mythtv
  Commit: b1bb52dd86ced27f4fa713b60109351a4f7f19d0
      https://github.com/MythTV/mythtv/commit/b1bb52dd86ced27f4fa713b60109351a4f7f19d0
  Author: Steve Erlenborn <1751095+SteveErl at users.noreply.github.com>
  Date:   2025-05-17 (Sat, 17 May 2025)

  Changed paths:
    M mythtv/libs/libmyth/audio/audiooutputpulse.cpp

  Log Message:
  -----------
  Close file leak in PulseAudio output handler (#1098)

According to the PulseAudio Destruction documentation,

"When the PulseAudio connection has been terminated,
the thread must be stopped and the resources freed.
Stopping the thread is done using
pa_threaded_mainloop_stop(), which must be called
without the lock (see below) held. When that
function returns, the thread is stopped and
the pa_threaded_mainloop object can be freed using
pa_threaded_mainloop_free()."

The code in audiooutputpulse.cpp called
pa_threaded_mainloop_stop(), but never called
pa_threaded_mainloop_free(). That missing call is
what frees up allocated resources like FIFO files.

The missing calls to pa_threaded_mainloop_free() have
been added in this modification.

Resolves: #1095



To unsubscribe from these emails, change your notification settings at https://github.com/MythTV/mythtv/settings/notifications