[mythtv-commits] [MythTV/mythtv] cea210: libmythupnp: reduce unnecessary and transitive inc...

Tue May 13 01:39:09 UTC 2025

  Branch: refs/heads/master
  Home:   https://github.com/MythTV/mythtv
  Commit: cea21021cb49a388fd09968da49ea49954263d0a
      https://github.com/MythTV/mythtv/commit/cea21021cb49a388fd09968da49ea49954263d0a
  Author: Scott Theisen <scott.the.elm at gmail.com>
  Date:   2025-05-12 (Mon, 12 May 2025)

  Changed paths:
    M mythtv/libs/libmyth/backendselect.cpp
    M mythtv/libs/libmyth/mythcontext.cpp
    M mythtv/libs/libmythupnp/bufferedsocketdevice.cpp
    M mythtv/libs/libmythupnp/bufferedsocketdevice.h
    M mythtv/libs/libmythupnp/eventing.cpp
    M mythtv/libs/libmythupnp/htmlserver.cpp
    M mythtv/libs/libmythupnp/httprequest.cpp
    M mythtv/libs/libmythupnp/httpserver.cpp
    M mythtv/libs/libmythupnp/httpserver.h
    M mythtv/libs/libmythupnp/mmulticastsocketdevice.cpp
    M mythtv/libs/libmythupnp/mythxmlclient.cpp
    M mythtv/libs/libmythupnp/serializers/xmlplistSerializer.cpp
    M mythtv/libs/libmythupnp/serverSideScripting.cpp
    M mythtv/libs/libmythupnp/serverSideScripting.h
    M mythtv/libs/libmythupnp/servicehost.cpp
    M mythtv/libs/libmythupnp/servicehost.h
    M mythtv/libs/libmythupnp/soapclient.cpp
    M mythtv/libs/libmythupnp/ssdp.h
    M mythtv/libs/libmythupnp/ssdpcache.h
    M mythtv/libs/libmythupnp/taskqueue.cpp
    M mythtv/libs/libmythupnp/taskqueue.h
    M mythtv/libs/libmythupnp/upnp.cpp
    M mythtv/libs/libmythupnp/upnp.h
    M mythtv/libs/libmythupnp/upnpcds.cpp
    M mythtv/libs/libmythupnp/upnpcdsobjects.cpp
    M mythtv/libs/libmythupnp/upnpcmgr.cpp
    M mythtv/libs/libmythupnp/upnpdevice.cpp
    M mythtv/libs/libmythupnp/upnpdevice.h
    M mythtv/libs/libmythupnp/upnpmsrr.cpp
    M mythtv/libs/libmythupnp/upnpmsrr.h
    M mythtv/libs/libmythupnp/upnpserviceimpl.h
    M mythtv/libs/libmythupnp/upnpsubscription.cpp
    M mythtv/libs/libmythupnp/upnpsubscription.h
    M mythtv/libs/libmythupnp/upnptaskevent.cpp
    M mythtv/libs/libmythupnp/upnptaskevent.h
    M mythtv/libs/libmythupnp/upnptasknotify.cpp
    M mythtv/libs/libmythupnp/upnptasknotify.h
    M mythtv/libs/libmythupnp/upnptasksearch.cpp
    M mythtv/libs/libmythupnp/upnptasksearch.h
    M mythtv/libs/libmythupnp/upnputil.cpp
    M mythtv/libs/libmythupnp/websocket_extensions/websocket_mythevent.cpp
    M mythtv/libs/libmythupnp/wsdl.h
    M mythtv/libs/libmythupnp/xsd.cpp
    M mythtv/libs/libmythupnp/xsd.h
    M mythtv/programs/mythbackend/httpstatus.cpp
    M mythtv/programs/mythbackend/mythbackend_main_helpers.cpp
    M mythtv/programs/mythbackend/servicesv2/v2status.cpp
    M mythtv/programs/mythfrontend/mediarenderer.cpp

  Log Message:
  -----------
  libmythupnp: reduce unnecessary and transitive includes

  Commit: 9b1e0dae9b7eeebc7b972df580547ca0459a0bc3
      https://github.com/MythTV/mythtv/commit/9b1e0dae9b7eeebc7b972df580547ca0459a0bc3
  Author: Scott Theisen <scott.the.elm at gmail.com>
  Date:   2025-05-12 (Mon, 12 May 2025)

  Changed paths:
    M mythtv/libs/libmythupnp/eventing.cpp
    M mythtv/libs/libmythupnp/eventing.h
    M mythtv/libs/libmythupnp/httprequest.h
    M mythtv/libs/libmythupnp/ssdpcache.cpp
    M mythtv/libs/libmythupnp/ssdpcache.h
    M mythtv/libs/libmythupnp/taskqueue.cpp
    M mythtv/libs/libmythupnp/taskqueue.h
    M mythtv/libs/libmythupnp/upnpdevice.h
    M mythtv/libs/libmythupnp/upnputil.h

  Log Message:
  -----------
  remove TaskTime

Using std::chrono::microseconds directly is clearer and reduces
transitive includes of libmythupnp/upnputil.h.

  Commit: 6229b05363ad0fecab5b2ed3a687038954cf8e70
      https://github.com/MythTV/mythtv/commit/6229b05363ad0fecab5b2ed3a687038954cf8e70
  Author: Scott Theisen <scott.the.elm at gmail.com>
  Date:   2025-05-12 (Mon, 12 May 2025)

  Changed paths:
    M mythtv/html/tv/schedule.qsp
    M mythtv/libs/libmythservicecontracts/CMakeLists.txt
    R mythtv/libs/libmythservicecontracts/datacontracts/enum.h
    R mythtv/libs/libmythservicecontracts/datacontracts/enumItem.h
    M mythtv/libs/libmythservicecontracts/libmythservicecontracts.pro
    R mythtv/libs/libmythservicecontracts/services/rttiServices.h
    M mythtv/libs/libmythupnp/CMakeLists.txt
    M mythtv/libs/libmythupnp/htmlserver.cpp
    M mythtv/libs/libmythupnp/httpserver.cpp
    M mythtv/libs/libmythupnp/libmythupnp.pro
    R mythtv/libs/libmythupnp/serviceHosts/rttiServiceHost.h
    M mythtv/libs/libmythupnp/servicehost.cpp
    R mythtv/libs/libmythupnp/services/rtti.cpp
    R mythtv/libs/libmythupnp/services/rtti.h

  Log Message:
  -----------
  remove Rtti

git grep -n GetEnum
matches only a commented out line in mythtv/html/tv/schedule.qsp

I believe this was for the WebFrontend using Qt Script, but never used.

It appears to be originally Rtti::GetEnumDetails() from
https://github.com/MythTV/mythtv/commit/cfcaf150ca387ac84c2de71ab8103fa6a618a698

Became GetEnum() in
https://github.com/MythTV/mythtv/commit/ad4c1052335d44c8b205a633f302170c81962710

Current commented out use from
https://github.com/MythTV/mythtv/commit/4d7f98a92cbdb7d69dc98065c68e9eddf8630966

  Commit: 77ffaf2b2c233944f7279684f06ba44d1ff502c2
      https://github.com/MythTV/mythtv/commit/77ffaf2b2c233944f7279684f06ba44d1ff502c2
  Author: Scott Theisen <scott.the.elm at gmail.com>
  Date:   2025-05-12 (Mon, 12 May 2025)

  Changed paths:
    M mythtv/libs/libmythupnp/CMakeLists.txt
    M mythtv/libs/libmythupnp/libmythupnp.pro
    R mythtv/libs/libmythupnp/servicehost.cpp
    R mythtv/libs/libmythupnp/servicehost.h
    R mythtv/libs/libmythupnp/wsdl.cpp
    R mythtv/libs/libmythupnp/wsdl.h
    R mythtv/libs/libmythupnp/xsd.cpp
    R mythtv/libs/libmythupnp/xsd.h
    M mythtv/programs/mythfrontend/CMakeLists.txt
    M mythtv/programs/mythfrontend/mythfrontend.pro
    M mythtv/programs/mythfrontend/serviceHosts/frontendServiceHost.h
    A mythtv/programs/mythfrontend/serviceHosts/servicehost.cpp
    A mythtv/programs/mythfrontend/serviceHosts/servicehost.h
    A mythtv/programs/mythfrontend/serviceHosts/wsdl.cpp
    A mythtv/programs/mythfrontend/serviceHosts/wsdl.h
    A mythtv/programs/mythfrontend/serviceHosts/xsd.cpp
    A mythtv/programs/mythfrontend/serviceHosts/xsd.h

  Log Message:
  -----------
  move ServiceHost to mythfrontend

  Commit: ba96970b600117809ec68a97de0c22c8635a5453
      https://github.com/MythTV/mythtv/commit/ba96970b600117809ec68a97de0c22c8635a5453
  Author: Scott Theisen <scott.the.elm at gmail.com>
  Date:   2025-05-12 (Mon, 12 May 2025)

  Changed paths:
    M mythtv/libs/libmyth/libmyth.pro
    M mythtv/libs/libmyth/test/test_audioconvert/test_audioconvert.pro
    M mythtv/libs/libmyth/test/test_audioutils/test_audioutils.pro
    M mythtv/libs/libmythmetadata/CMakeLists.txt
    M mythtv/libs/libmythmetadata/libmythmetadata.pro
    M mythtv/libs/libmythmetadata/test/test_lyrics/test_lyrics.pro
    M mythtv/libs/libmythmetadata/test/test_metadatagrabber/test_metadatagrabber.pro
    M mythtv/libs/libmythmetadata/test/test_musicmetadata/test_musicmetadata.pro
    M mythtv/libs/libmythmetadata/test/test_musicutils/test_musicutils.pro
    M mythtv/libs/libmythmetadata/test/test_videometadata/test_videometadata.pro
    M mythtv/libs/libmythprotoserver/libmythprotoserver.pro
    M mythtv/libs/libmythtv/CMakeLists.txt
    M mythtv/libs/libmythtv/libmythtv.pro
    M mythtv/libs/libmythtv/test/test_copyframes/test_copyframes.pro
    M mythtv/libs/libmythtv/test/test_eitfixups/test_eitfixups.pro
    M mythtv/libs/libmythtv/test/test_frequencies/test_frequencies.pro
    M mythtv/libs/libmythtv/test/test_iptvrecorder/test_iptvrecorder.pro
    M mythtv/libs/libmythtv/test/test_mheg_dsmcc/test_mheg_dsmcc.pro
    M mythtv/libs/libmythtv/test/test_mpegtables/test_mpegtables.pro
    M mythtv/libs/libmythtv/test/test_mythiowrapper/test_mythiowrapper.pro
    M mythtv/libs/libmythtv/test/test_subtitlescreen/test_subtitlescreen.pro
    M mythtv/libs/libmythupnp/CMakeLists.txt
    M mythtv/libs/libmythupnp/libmythupnp.pro
    M mythtv/libs/libs.pro
    M mythtv/programs/mythbackend/CMakeLists.txt
    M mythtv/programs/mythbackend/test/test_recordingextender/test_recordingextender.pro

  Log Message:
  -----------
  remove unnecessary references to libmythservicecontracts

  Commit: 353c95c644e177db82af1077b5a528b44a30f424
      https://github.com/MythTV/mythtv/commit/353c95c644e177db82af1077b5a528b44a30f424
  Author: Scott Theisen <scott.the.elm at gmail.com>
  Date:   2025-05-12 (Mon, 12 May 2025)

  Changed paths:
    M mythplugins/programs-libs.pro
    M mythtv/CMakeLists.txt
    M mythtv/i18n/translate.pro
    M mythtv/libs/CMakeLists.txt
    R mythtv/libs/libmythservicecontracts/CMakeLists.txt
    R mythtv/libs/libmythservicecontracts/datacontracthelper.h
    R mythtv/libs/libmythservicecontracts/datacontracts/frontendActionList.h
    R mythtv/libs/libmythservicecontracts/datacontracts/frontendStatus.h
    R mythtv/libs/libmythservicecontracts/libmythservicecontracts.pro
    R mythtv/libs/libmythservicecontracts/service.cpp
    R mythtv/libs/libmythservicecontracts/service.h
    R mythtv/libs/libmythservicecontracts/serviceexp.h
    R mythtv/libs/libmythservicecontracts/services/frontendServices.h
    M mythtv/libs/libs.pro
    M mythtv/programs/mythfrontend/CMakeLists.txt
    M mythtv/programs/mythfrontend/mythfrontend.pro
    M mythtv/programs/mythfrontend/serviceHosts/servicehost.h
    A mythtv/programs/mythfrontend/servicecontracts/datacontracthelper.h
    A mythtv/programs/mythfrontend/servicecontracts/frontendActionList.h
    A mythtv/programs/mythfrontend/servicecontracts/frontendServices.h
    A mythtv/programs/mythfrontend/servicecontracts/frontendStatus.h
    A mythtv/programs/mythfrontend/servicecontracts/service.cpp
    A mythtv/programs/mythfrontend/servicecontracts/service.h
    M mythtv/programs/mythfrontend/services/frontend.h
    M mythtv/programs/mythfrontend/test/test_videolist/test_videolist.pro
    M mythtv/programs/programs-libs.pro

  Log Message:
  -----------
  merge libmythservicecontracts into mythfrontend

Compare: https://github.com/MythTV/mythtv/compare/f2f1ce219711...353c95c644e1

To unsubscribe from these emails, change your notification settings at https://github.com/MythTV/mythtv/settings/notifications