[mythtv-commits] [MythTV/mythtv] 083468: Replace the _builtin_nanf() function with __builti...

Fri Jan 3 00:10:20 UTC 2025

  Branch: refs/heads/master
  Home:   https://github.com/MythTV/mythtv
  Commit: 0834681aa9dfc949a66f8b3c27616308fe8067a9
      https://github.com/MythTV/mythtv/commit/0834681aa9dfc949a66f8b3c27616308fe8067a9
  Author: David Hampton <mythtv at love2code.net>
  Date:   2025-01-02 (Thu, 02 Jan 2025)

  Changed paths:
    M mythplugins/mythmusic/mythmusic/bumpscope.cpp
    M mythplugins/mythmusic/mythmusic/playlist.cpp
    M mythtv/libs/libmythtv/diseqcsettings.cpp
    M mythtv/libs/libmythui/mythuitext.cpp

  Log Message:
  -----------
  Replace the _builtin_nanf() function with __builtin_nan().

The macro NAN is currently replaced with _builtin_nanf(), which
provides a floating point value that is then implicitly converted to
double precision.  Changing the code to use __builtin_nan() directly
provides a double precision value.  The end result should be the same
without the compilation warning.

  Commit: 2dfd18b5215c0eaeb84fa2b94b64f1beda384884
      https://github.com/MythTV/mythtv/commit/2dfd18b5215c0eaeb84fa2b94b64f1beda384884
  Author: David Hampton <mythtv at love2code.net>
  Date:   2025-01-02 (Thu, 02 Jan 2025)

  Changed paths:
    M mythplugins/mythmusic/mythmusic/synaesthesia.cpp

  Log Message:
  -----------
  Slight tweak to Synaesthesia::process.

Pull the variable assignment out of the call to sqrt() and put it on
the same line as its declaration.  This prevents an "assigned but
unused" warning message.

  Commit: aa5da9aa44a13ee2e90a6246d880109ce88496df
      https://github.com/MythTV/mythtv/commit/aa5da9aa44a13ee2e90a6246d880109ce88496df
  Author: David Hampton <mythtv at love2code.net>
  Date:   2025-01-02 (Thu, 02 Jan 2025)

  Changed paths:
    M mythtv/libs/libmythtv/channelscan/channelscanner.cpp

  Log Message:
  -----------
  Simplify type determination in ChannelScanner::ImportDVBUtils.

Replace a series of ternary operators with a simple switch statement.

  Commit: 6dd8e2a3b03526014b31c1c844031724af14abd8
      https://github.com/MythTV/mythtv/commit/6dd8e2a3b03526014b31c1c844031724af14abd8
  Author: David Hampton <mythtv at love2code.net>
  Date:   2025-01-02 (Thu, 02 Jan 2025)

  Changed paths:
    M mythtv/libs/libmythtv/channelscan/channelscanner.cpp
    M mythtv/libs/libmythtv/dtvconfparser.cpp
    M mythtv/libs/libmythtv/dtvconfparser.h

  Log Message:
  -----------
  Convert two DTVConfParser enums to enum classes.

This allows removal of the clang pragma as its no longer possible for
QPSK (from /usr/include/linux/dvb/frontend.h) and cardtype_t::QPSK to
shadow each other.

  Commit: 4f6b0f8b05b4d733421d9476b1f8f1e5ab023eb0
      https://github.com/MythTV/mythtv/commit/4f6b0f8b05b4d733421d9476b1f8f1e5ab023eb0
  Author: David Hampton <mythtv at love2code.net>
  Date:   2025-01-02 (Thu, 02 Jan 2025)

  Changed paths:
    M mythtv/libs/libmythtv/cardutil.h
    M mythtv/libs/libmythtv/channelscan/channelscanner.cpp
    M mythtv/libs/libmythtv/channelscan/channelscanner.h
    M mythtv/libs/libmythtv/channelscan/channelscanner_web.cpp
    M mythtv/libs/libmythtv/channelscan/scanwizardconfig.cpp
    M mythtv/libs/libmythtv/recorders/satiputils.cpp
    M mythtv/libs/libmythtv/scanwizard.cpp
    M mythtv/libs/libmythtv/scanwizard.h
    M mythtv/libs/libmythtv/transporteditor.cpp
    M mythtv/libs/libmythtv/transporteditor.h
    M mythtv/libs/libmythtv/videosource.cpp
    M mythtv/programs/mythbackend/servicesv2/v2capture.cpp

  Log Message:
  -----------
  Convert the CardUtil::INPUT_TYPES enum to enum classes.

This allows removal of the clang pragma as its no longer possible for
QPSK (from /usr/include/linux/dvb/frontend.h) and INPUT_TYPES::QPSK to
shadow each other.

  Commit: 15a6520b0835738ddea2f04f6f9b7765830bc1f7
      https://github.com/MythTV/mythtv/commit/15a6520b0835738ddea2f04f6f9b7765830bc1f7
  Author: David Hampton <mythtv at love2code.net>
  Date:   2025-01-02 (Thu, 02 Jan 2025)

  Changed paths:
    M mythtv/bindings/python/CMakeLists.txt
    M mythtv/programs/scripts/CMakeLists.txt

  Log Message:
  -----------
  cmake: Quiet build time output for python scripts.

Setting the environment variable VERBOSE=1 to the cmake build step
will print each command before it is executed.

  Commit: c207fa0f599b95d89e8c8dcf77f963aadce66a7a
      https://github.com/MythTV/mythtv/commit/c207fa0f599b95d89e8c8dcf77f963aadce66a7a
  Author: David Hampton <mythtv at love2code.net>
  Date:   2025-01-02 (Thu, 02 Jan 2025)

  Changed paths:
    M mythtv/libs/libmythtv/HLS/httplivestreambuffer.cpp

  Log Message:
  -----------
  Fix potential null pointer dereferences in httplivestreambuffer.cpp.

The GetStream() and GetCurrentStream() functions can return a nullptr.
The return from these functions must be tested before dereferencing
the (possibly null) pointer.

  Commit: c637c2705d868fbcec5cfed761526787cca395cd
      https://github.com/MythTV/mythtv/commit/c637c2705d868fbcec5cfed761526787cca395cd
  Author: David Hampton <mythtv at love2code.net>
  Date:   2025-01-02 (Thu, 02 Jan 2025)

  Changed paths:
    M mythtv/libs/libmythtv/channelscan/channelscan_sm.cpp

  Log Message:
  -----------
  Fix potential null pointer dereferences in channelscan_sm.cpp.

The GetDTVSignalMonitor() functions (and others) can return a nullptr.
The return from these functions must be tested before dereferencing
the (possibly null) pointer.

  Commit: 5a27ac6093b0cc584d14a8d467af9812cd27a0f2
      https://github.com/MythTV/mythtv/commit/5a27ac6093b0cc584d14a8d467af9812cd27a0f2
  Author: David Hampton <mythtv at love2code.net>
  Date:   2025-01-02 (Thu, 02 Jan 2025)

  Changed paths:
    M mythtv/libs/libmythtv/tv_rec.cpp

  Log Message:
  -----------
  Fix potential null pointer dereferences in tv_rec.cpp.

The GetATSCStreamData() function can return a nullptr.  The return
from this functions must be tested before dereferencing the (possibly
null) pointer.

  Commit: 9569fb23652958ce2bef1b87f1247c42b37e4237
      https://github.com/MythTV/mythtv/commit/9569fb23652958ce2bef1b87f1247c42b37e4237
  Author: David Hampton <mythtv at love2code.net>
  Date:   2025-01-02 (Thu, 02 Jan 2025)

  Changed paths:
    M mythtv/libs/libmythtv/eithelper.cpp

  Log Message:
  -----------
  Fix potential null pointer dereferences in eithelper.cpp.

Descriptor constructor functions can return an invalid object, i.e. no
data pointer.  Check that the descriptor is valid before before
dereferencing the (possibly null) data pointer.

  Commit: f81d2731b1c120e31460f39db50f9a32850a8fe2
      https://github.com/MythTV/mythtv/commit/f81d2731b1c120e31460f39db50f9a32850a8fe2
  Author: David Hampton <mythtv at love2code.net>
  Date:   2025-01-02 (Thu, 02 Jan 2025)

  Changed paths:
    M mythtv/programs/mythfrontend/videodlg.cpp

  Log Message:
  -----------
  Fix potential null pointer dereferences in videodlg.cpp.

The compiler seems to believe that the m_d->m_videoList can be changed
inside of some of these functions.  Adding additional checks on the
validity of this pointer eliminates changes of dereferencing the
(possibly null) data pointer.

Unsure why putting the results of getListCache() into a temporary
variable eliminates the compiler warning about a null dereference,
unless somehow that forces the compiler to prune paths and prune out
the path that includes the nullptr.

Compare: https://github.com/MythTV/mythtv/compare/1ade8170c5c4...f81d2731b1c1

To unsubscribe from these emails, change your notification settings at https://github.com/MythTV/mythtv/settings/notifications