[mythtv-commits] [MythTV/mythtv] dff4f7: tidy: Move assignments to constructor member initi...

[David Hampton]

  Branch: refs/heads/master
  Home:   https://github.com/MythTV/mythtv
  Commit: dff4f79e77d8944ee6a693a9ac72d0d875a760df
      https://github.com/MythTV/mythtv/commit/dff4f79e77d8944ee6a693a9ac72d0d875a760df
  Author: David Hampton <mythtv at love2code.net>
  Date:   2024-11-28 (Thu, 28 Nov 2024)

  Changed paths:
    M mythtv/libs/libmythtv/mythplayerui.cpp

  Log Message:
  -----------
  tidy: Move assignments to constructor member initialization list.

Promote member initialization by assignment in the body of the
constructor to be part of the constructor initialization list.

https://clang.llvm.org/extra/clang-tidy/checks/cppcoreguidelines/prefer-member-initializer.html


  Commit: 58a822d19d56dbe58f3638aca6ea20af6df67b6b
      https://github.com/MythTV/mythtv/commit/58a822d19d56dbe58f3638aca6ea20af6df67b6b
  Author: David Hampton <mythtv at love2code.net>
  Date:   2024-11-28 (Thu, 28 Nov 2024)

  Changed paths:
    M mythtv/libs/libmythtv/recorders/ExternalStreamHandler.cpp

  Log Message:
  -----------
  tidy: Clean up a couple of variable initializations.

1) Add a null initializer for a complex variable.

2) Reduce the scope of a varabile and initialize it with a default value.

https://clang.llvm.org/extra/clang-tidy/checks/cppcoreguidelines/pro-type-member-init.html
https://clang.llvm.org/extra/clang-tidy/checks/cppcoreguidelines/init-variables.html


  Commit: 3bed63376fabc99979c1e76e17a543c5269e8c8d
      https://github.com/MythTV/mythtv/commit/3bed63376fabc99979c1e76e17a543c5269e8c8d
  Author: David Hampton <mythtv at love2code.net>
  Date:   2024-11-28 (Thu, 28 Nov 2024)

  Changed paths:
    M mythtv/libs/libmythtv/recorders/ExternalStreamHandler.cpp

  Log Message:
  -----------
  tidy: Add braces around else clause.

For consistency and ease of readability, once an if/then/else clause
has started using braces around the bodies of an "if" clause, it
should use braces around all the rest of the bodies.

https://clang.llvm.org/extra/clang-tidy/checks/readability/braces-around-statements.html


  Commit: 0ebdbda22da7ea4637d00a483c30e19a58497270
      https://github.com/MythTV/mythtv/commit/0ebdbda22da7ea4637d00a483c30e19a58497270
  Author: David Hampton <mythtv at love2code.net>
  Date:   2024-11-28 (Thu, 28 Nov 2024)

  Changed paths:
    M mythtv/libs/libmythtv/recorders/ExternalStreamHandler.cpp

  Log Message:
  -----------
  clazy: Use qstring multi-arg for consecutive string arguments.

This is more efficient as it only performs a single memory allocation
instead of two memory allocations.

https://github.com/KDE/clazy/blob/master/docs/checks/README-qstring-arg.md


  Commit: 73ba5a77b5ce824750a10e984bf8ff898ebe79b5
      https://github.com/MythTV/mythtv/commit/73ba5a77b5ce824750a10e984bf8ff898ebe79b5
  Author: David Hampton <mythtv at love2code.net>
  Date:   2024-11-28 (Thu, 28 Nov 2024)

  Changed paths:
    M mythtv/libs/libmythtv/recorders/rtp/packetbuffer.cpp

  Log Message:
  -----------
  tidy: Suppress "unnecessary copy initialization" warning.


  Commit: 6696609ad9f2c0b32808c421755161d440041378
      https://github.com/MythTV/mythtv/commit/6696609ad9f2c0b32808c421755161d440041378
  Author: David Hampton <mythtv at love2code.net>
  Date:   2024-11-28 (Thu, 28 Nov 2024)

  Changed paths:
    M mythtv/programs/mythfilldatabase/xmltvparser.cpp

  Log Message:
  -----------
  Check for empty XML file before attempting to parse it.

This should provide a better error message when an XMLTV fails.


Compare: https://github.com/MythTV/mythtv/compare/15b6a01b5897...6696609ad9f2

To unsubscribe from these emails, change your notification settings at https://github.com/MythTV/mythtv/settings/notifications